Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-338: [Java][CI] Upgrade Arrow Java version for Java Cookbooks #339

Merged
merged 7 commits into from
Feb 12, 2024
Merged

GH-338: [Java][CI] Upgrade Arrow Java version for Java Cookbooks #339

merged 7 commits into from
Feb 12, 2024

Conversation

davisusanibar
Copy link
Contributor

To closes #338

@davisusanibar
Copy link
Contributor Author

Need to review https://nightlies.apache.org/arrow/java/org/apache/arrow/ for new Java modules added:

  • bom
  • maven
  • netty patch

@amoeba amoeba mentioned this pull request Feb 1, 2024
Merged
@raulcd
Copy link
Member

raulcd commented Feb 1, 2024

Thanks @davisusanibar , as there is a small script to update versions I would run the automated one and do it on a single PR. See my comment here: #343

@davisusanibar
Copy link
Contributor Author

Is needed to review Arrow Java Dataset on Linuz environment.

  • MacOS: OK
  • Linux: NOK
2024-02-07T16:15:45.7564602Z Document: dataset
2024-02-07T16:15:45.7565106Z -----------------
2024-02-07T16:15:49.6220918Z SLF4J(W): No SLF4J providers were found.
2024-02-07T16:15:49.6646043Z SLF4J(W): Defaulting to no-operation (NOP) logger implementation
2024-02-07T16:15:49.6647689Z SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
2024-02-07T16:15:49.6649325Z SLF4J(W): Class path contains SLF4J bindings targeting slf4j-api versions 1.7.x or earlier.
2024-02-07T16:15:49.6651710Z SLF4J(W): Ignoring binding found at [jar:file:/home/runner/.m2/repository/org/slf4j/slf4j-jdk14/1.7.30/slf4j-jdk14-1.7.30.jar!/org/slf4j/impl/StaticLoggerBinder.class]
2024-02-07T16:15:49.6654062Z SLF4J(W): See https://www.slf4j.org/codes.html#ignoredBindings for an explanation.
2024-02-07T16:15:50.0969022Z Exception java.lang.UnsatisfiedLinkError: /tmp/jnilib-5670360797150962767.tmp: /tmp/jnilib-5670360797150962767.tmp: undefined symbol: _ZTIN6google8protobuf7MessageE
2024-02-07T16:15:50.0970774Z       at NativeLibraries.load (Native Method)
2024-02-07T16:15:50.0977239Z       at NativeLibraries$NativeLibraryImpl.open (NativeLibraries.java:395)
2024-02-07T16:15:50.0978296Z       at NativeLibraries.loadLibrary (NativeLibraries.java:234)
2024-02-07T16:15:50.0979275Z       at NativeLibraries.loadLibrary (NativeLibraries.java:176)
2024-02-07T16:15:50.0980137Z       at ClassLoader.loadLibrary (ClassLoader.java:2394)
2024-02-07T16:15:50.1068329Z       at Runtime.load0 (Runtime.java:785)
2024-02-07T16:15:50.1070185Z       at System.load (System.java:1979)
2024-02-07T16:15:50.1071985Z       at JniLoader.load (JniLoader.java:92)
2024-02-07T16:15:50.1073983Z       at JniLoader.loadRemaining (JniLoader.java:75)
2024-02-07T16:15:50.1076186Z       at JniLoader.ensureLoaded (JniLoader.java:61)
2024-02-07T16:15:50.1077401Z       at NativeMemoryPool.getDefault (NativeMemoryPool.java:34)
2024-02-07T16:15:50.1078292Z       at (#13:3)
2024-02-07T16:15:50.4281061Z **********************************************************************
2024-02-07T16:15:50.4291663Z File "dataset.rst", line 65, in default

vibhatha
vibhatha reviewed Feb 10, 2024
View reviewed changes
java/source/conf.py Outdated
@@ -38,9 +38,9 @@
author = 'The Apache Software Foundation'
arrow_nightly=os.getenv("ARROW_NIGHTLY")
if arrow_nightly and arrow_nightly != '0':
version = "15.0.0-SNAPSHOT"
version = "15.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "15.0.0"
version = "16.0.0-SNAPSHOT"

vibhatha
vibhatha reviewed Feb 10, 2024
View reviewed changes
java/ext/javadoctest.py Outdated
@@ -47,6 +47,10 @@ def compile(
) -> Any:
# go to project that contains all your arrow maven dependencies
path_arrow_project = pathlib.Path(__file__).parent.parent / "source" / "demo"
# delete classpath java dependencies files used
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the main reason to add this for Arrow Java version upgrade?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vibhatha this change was for testing purpose, let me update with final changes

@vibhatha
Copy link
Contributor

Seems like all the CIs are passing. Does it mean that we have resolved the protobuf related problem?

@davisusanibar
Copy link
Contributor Author

Seems like all the CIs are passing. Does it mean that we have resolved the protobuf related problem?

You're right, it is. PR related: apache/arrow#40015

@davisusanibar
Copy link
Contributor Author

I would appreciate a review from you @lidavidm.

@lidavidm lidavidm merged commit 90a3406 into apache:main Feb 12, 2024
6 checks passed
raulcd pushed a commit that referenced this pull request Feb 13, 2024
@amoeba
MINOR: [Release] Update C++ and PyArrow versions for 15.0.0 (#343)
440f5e0 
Can't easily test this locally so sending a PR to see what CI looks
like. Java changes are in a separate PR:
#339.

@raulcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibhatha vibhatha vibhatha left review comments

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Java][CI] Test cookbooks against Apache Arrow Java v15.0.0
4 participants
@davisusanibar @raulcd @vibhatha @lidavidm