Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: include libyaml in image and use docker compose #562

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

TheShubhendra
Copy link
Contributor

This pull request includes updates to the CI workflow to address build issues.

Changes

  1. Build libyaml before installing lyaml:

    • Added a step to build and install libyaml before attempting to install the lyaml Lua module.
    • This change resolves the issue where lyaml installation fails due to missing libyaml symbols.
  2. Switch from docker-compose to docker compose:

    • Updated the CI workflow to replace docker-compose with docker compose for compatibility with newer Docker versions.

…se` for compatibility with newer Docker versions
@TheShubhendra TheShubhendra marked this pull request as draft August 5, 2024 19:00
@TheShubhendra TheShubhendra marked this pull request as ready for review August 6, 2024 02:56
@TheShubhendra
Copy link
Contributor Author

@shreemaan-abhishek Can you please run the workflows?

@kayx23
Copy link
Member

kayx23 commented Aug 13, 2024

all checks passed

Copy link
Contributor

@shreemaan-abhishek shreemaan-abhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreemaan-abhishek shreemaan-abhishek changed the title ci: Update CI workflow to build libyaml and use docker compose ci: include libyaml in image and use docker compose Aug 14, 2024
@shreemaan-abhishek shreemaan-abhishek merged commit 2993386 into apache:master Aug 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants