-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: include libyaml in image and use docker compose #562
Merged
shreemaan-abhishek
merged 4 commits into
apache:master
from
TheShubhendra:fix-ci-pipelines
Aug 14, 2024
Merged
ci: include libyaml in image and use docker compose #562
shreemaan-abhishek
merged 4 commits into
apache:master
from
TheShubhendra:fix-ci-pipelines
Aug 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se` for compatibility with newer Docker versions
TheShubhendra
force-pushed
the
fix-ci-pipelines
branch
from
August 5, 2024 18:47
a861536
to
89929f9
Compare
TheShubhendra
force-pushed
the
fix-ci-pipelines
branch
from
August 5, 2024 18:51
89929f9
to
d438275
Compare
@shreemaan-abhishek Can you please run the workflows? |
all checks passed |
shreemaan-abhishek
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shreemaan-abhishek
changed the title
ci: Update CI workflow to build libyaml and use docker compose
ci: include libyaml in image and use docker compose
Aug 14, 2024
moonming
approved these changes
Aug 14, 2024
shreemaan-abhishek
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the CI workflow to address build issues.
Changes
Build libyaml before installing lyaml:
Switch from docker-compose to docker compose:
docker-compose
withdocker compose
for compatibility with newer Docker versions.