fix: use sed replace yq #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revolyssup
requested changes
Sep 27, 2023
centos/docker-entrypoint.sh
Outdated
| /usr/local/apisix/yq -i '.deployment.role = "data_plane"' ${PREFIX}/conf/config.yaml | ||
| /usr/local/apisix/yq -i '.deployment.role_data_plane.config_provider = "yaml"' ${PREFIX}/conf/config.yaml | ||
| rm /usr/local/apisix/yq | ||
| sed -i 's/role: traditional/role: data_plane/' config.yaml |
There was a problem hiding this comment.
I dont think we need to match only when role: traditional and config_provider is etcd.
It should be replaced in any case which is role: * and config_provider: *
There was a problem hiding this comment.
Sorry for replying to you so late.
I think there may be other role configurations in config , such as:
test:
role: xxx
|
@kamly please fix the ci |
Revolyssup
requested changes
Sep 28, 2023
|
fix it ~ |
Revolyssup
approved these changes
Sep 28, 2023
lingsamuel
approved these changes
Sep 28, 2023
monkeyDluffy6017
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: use sed replace yq