fix: allow config.yaml to be updated when already present for standalone mode #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one mode Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
Revolyssup
requested review from
soulbird,
shreemaan-abhishek and
monkeyDluffy6017
and removed request for
soulbird
There was a problem hiding this comment.
Please add a test like this: https://github.com/apache/apisix-docker/blob/master/.github/workflows/apisix-docker-example-test.yaml
For standalone mode.
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
kayx23
approved these changes
Sep 8, 2023
shreemaan-abhishek
previously requested changes
Sep 8, 2023
soulbird
reviewed
Sep 8, 2023
soulbird
reviewed
Sep 8, 2023
soulbird
approved these changes
Sep 11, 2023
leslie-tsang
approved these changes
Sep 11, 2023
kayx23
dismissed
shreemaan-abhishek’s stale review
proposed change already done
AlinsRan
pushed a commit
that referenced
this pull request
Sep 11, 2023
…one mode (#494) (#497) Signed-off-by: Ashish Tiwari <[email protected]>
|
hi, why delete I think this judgment is needed, If delete it, there will be an error message. 
|
|
@kamly This if condition check wasn't removed in the PR |
|
@kamly You're right. But this still didn't cause the issue. The issue was because it takes time for few things to be setup in container now. Though this is still an issue because it removed apisix.yaml. I will readd it. |
|
i fix it #502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #495
In this PR https://github.com/apache/apisix-docker/pull/491/files, the logic was changed so that if config.yaml is already present then it is not updated or initialised.
But the update is necessary for standalone mode where config_provider is changed to config.yaml.
This change makes sure that if the file doesn't exist then it is initialised. Otherwise relevant fields are updated for standalone mode
NOTE: yq utility is being downloaded at runtime so the startup time for standalone mode might increase by few seconds.