Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Fix incorrect parameter naming of some TableExecutor #3342

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

huyuanfeng2018
Copy link
Contributor

Why are the changes needed?

Close #xxx.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Nov 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.40%. Comparing base (243d289) to head (b9a8c4f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3342      +/-   ##
============================================
+ Coverage     21.59%   27.40%   +5.81%     
- Complexity     2309     3503    +1194     
============================================
  Files           426      591     +165     
  Lines         39719    48237    +8518     
  Branches       5624     6228     +604     
============================================
+ Hits           8577    13219    +4642     
- Misses        30414    34085    +3671     
- Partials        728      933     +205     
Flag Coverage Δ
core 27.40% <100.00%> (?)
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the work!

@huyuanfeng2018 huyuanfeng2018 merged commit b5f6372 into apache:master Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants