Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-26236: The database password character type requirement is too few #3883

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

guluo2016
Copy link
Contributor

What changes were proposed in this pull request?

The database password character type requirement is too few.
It is recommended to support more character sets, For example: !#$%@.

When the database password we set contains some special characters,we can still setup ambari-server succefully after applying this changes.

How was this patch tested?

  1. Applying this changes
  2. Set the database password used by Ambari to contain special characters (eg a-zA-Z0-9!#$%@_-)
  3. Setup ambari-server

Please review Ambari Contributing Guide before opening a pull request.

Copy link
Contributor

@JiaLiangC JiaLiangC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include more special strings, like other systems, and it would be best to add some tests as well?

@guluo2016
Copy link
Contributor Author

OK, I'll add the test cases later. Thank you for your review!

@guluo2016
Copy link
Contributor Author

Add support for these characters a-zA-Z0-9!#$%@^&=+[]{}()<>.*?;:'"_-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants