AMBARI-26059: Update builder and resource provider #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…memstore.size' from Ambari (apache#3692)
* AMBARI-25946: Fix CI/CD error for Ambari WebUI Tests Signed-off-by: Brahma Reddy Battula <[email protected]>
…ache#3695) * AMBARI-25932: fix wrong config file name in spark service advisor * Trigger CI/CD * refactor spark2 related variable name to spark * fix * remove livy2 in spark advisor ,cause it not supported in bigtop 3.2 stack * remove spark sac and atlas related code,cause we haven't integrated Atlas yet.
…ement in configuration files for service was invalided (apache#3646)
…e#3677) * AMBARI-25894: Missing file service_advisor.py in some serivces * remove -Dhdp.version
apache#3708) Signed-off-by: Brahma Reddy Battula <[email protected]>
* AMBARI-25965: Upgrade service version to Bigtop 3.3.0 * remove service_advisor.py
…che#3712) Copied dashboards from https://github.com/apache/ambari/tree/branch-2.7/ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP as it is. Signed-off-by: Brahma Reddy Battula <[email protected]>
…afana dashboards. (apache#3727) Signed-off-by: Brahma Reddy Battula <[email protected]>
Signed-off-by: Brahma Reddy Battula <[email protected]>
Signed-off-by: Brahma Reddy Battula <[email protected]>
…rom 100 MB to 255 MB (apache#3728) Signed-off-by: Brahma Reddy Battula <[email protected]>
…performance improvement (apache#3672)
…ache#3747) Signed-off-by: Mohammad Arshad <[email protected]>
PhantomJS is a headless web browser scriptable with JavaScript. The package is no longer maintained and does not even support ES6 features of Javascript. Chrome launched ChromeHeadless which works very similar to PhantomJs. The fix will require Karma to use ChromeHeadless as the web browser instead of PhantomJs How was this patch tested? Ran test cases for ambari-web and it gives the desired reports. Please review Ambari Contributing Guide before opening a pull request. Karma Amabri web admin chrome headless Remve phantom js package Co-authored-by: Hassija, Vanshu <[email protected]> Signed-off-by: Mohammad Arshad <[email protected]>
Signed-off-by: Mohammad Arshad <[email protected]>
* AMBARI-26000 support python3 on trunk * remove yum since it's not supported in py3 * 1.fix shell decode error 2.fix sudo encoding error 3.remove redunant get_encoded_string * remove duplicate import * fix bugs * update ambari metrics to python3 * fix review comment Co-authored-by: jialiang <[email protected]> Co-authored-by: jialiang <[email protected]> Signed-off-by: Mohammad Arshad <[email protected]>
|
@tarihub thanks for reporting and working on this. Could you please add one Unit Test case for this and attach the validation snapshots after fixing this.? |
|
of course～ |
|
I've been a little busy lately, it might take a while |
|
Hi @brahmareddybattula , I add Unit Test for this problem which would be After patch, Unit Test will run successfully. Validation for this fix: script.filename can't be injectable. |
|
@tarihub looks like CI has not run for this PR. Can you rebase and push again? |
@sandeep318kumar hello, I merge the latest commit, but CI still not run update: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.