AMBARI-25978: add logsearch support for ambari #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rzuo It appears that your work is based on Python 2. Currently, the trunk has been upgraded to Python 3. Could you please upgrade your code to Python 3 and then test it? |
JiaLiangC
reviewed
Jul 27, 2024
| @@ -0,0 +1,85 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
As the Ambari trunk is currently using Python 3, you can refer to these services and uniformly set the Python interpreter to Python 3.
| @@ -0,0 +1,70 @@ | |||
| """ | |||
There was a problem hiding this comment.
All Python files must explicitly specify the Python 3 interpreter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ambari-logsearch has been a sub-project of ambari, but the bigtop stack 3.2.0 doesn't support ambari-logsearch service.
To support ambari-logsearch, I proposed this PR.
For ambari-logsearch-portal fail to start, please refer to:
https://issues.apache.org/jira/browse/AMBARI-25992
For ambari-logsearch-logfeeder fail to start, please refer to:
https://issues.apache.org/jira/browse/AMBARI-25993
How was this patch tested?
local build ambari-3.0.0.0-SNAPSHOT on CentOS 7.9/x86_64
local build ambari-logsearch-3.0.0.0-SNAPSHOT on CentOS 7.9/x86_64
install the ambari-server and ambari-agent.
install ambari-logsearch-portal and ambari-logsearch-logfeeder.
visit ambari -> services -> Log Search, screenshot as following:
visit ambari-logsearch-portal web UI, screenshots as following:
Please review Ambari Contributing Guide before opening a pull request.