Skip to content
This repository has been archived by the owner on Aug 7, 2019. It is now read-only.

Adds HTTPHeaders for playing from http source #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

igorkravchenko
Copy link

Sometimes it is required to send HTTP headers along with URL. Is there a chance we can add this?

@mmcdole
Copy link

mmcdole commented Jan 30, 2015

👍 this would be amazing.

@sadhiappan
Copy link

I often have to play mp3s from sources that require oauth authorization headers.  This would help me out a lot. The changes made my @igorkravchenko looks pretty clean. Would love to have it in master.

@ap4y
Copy link
Owner

ap4y commented Jan 30, 2015

For some reason I missed this PR, I think I was on vacation around that time :) Will merge in next couple days.

@igorkravchenko
Copy link
Author

Still on vacation? ;)

@ap4y
Copy link
Owner

ap4y commented Jun 22, 2015

Sorry for not responding previously. I didn't merge this PR because I didn't like idea of having plugin specific options on engine mediator (plus some code styling issues). I tried to draft different implementation, but got sidetracked as always. Right now I'm not too interested in investing much time into new features, as described here. If someone needs this feature, I think it should be ok to use your branch or fork and patch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants