Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 10.1.48, 11.0.782 and partially 11.1.1201 #28

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Taloth
Copy link
Member

@Taloth Taloth commented Sep 26, 2024

Partially work in progress.

  • I changed the way pbg files are found in essence mode (probably breaking non-essence mode in the process). Within each pbgmap directory (top level dir), all files are unique, the directory structure doesn't matter. So I search the directory and create a map per top level directory. This allows for faster lookup.

  • Fixed issue where the code would pick the first variant in the pbg files, rather than searching and picking 'default'. this fixes the wrong stats being shown in 10.1.48

  • Processed 11.0.782 patch

  • Added more line of sight information, notably the LoS at same height was missing. explorer UI code needs to be changed to utilize this. (this was something someone mentioned to me on discord a while back)

  • Processed 11.1.1201 patch but some missing parts

    • I did add Khan's Hunter, but didn't fix their tech/abilities yet.
    • I noticed some discrepancies, like with Khan vision arrow missing, I had some work on that locally but not ready yet.
    • I moved around the way icons are processed, initially I moved em from before to after workarounds being applied, but this lead to a TON of icons being renamed, notably abilities that get assigned a age by workaround. So I changed it a bit so it stores the target name before workarounds, allowing workarounds to override it.
      I'd still advice to change it again to fixup those icon names, but I didn't want to change too much. I also think sticking 'age' to certain abilities is kinda pointless, but at least it holds a pattern atm.

Copy link
Member

@robertvanhoesel robertvanhoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing all this work. The refactor on Essence parsing is excellent!

I think we can fully rip out the xml parsing fwiw.

Want to go ahead and merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants