Skip to content

Commit

Permalink
update according to common admin
Browse files Browse the repository at this point in the history
  • Loading branch information
volar committed Apr 12, 2024
1 parent e7955db commit 1cc7191
Show file tree
Hide file tree
Showing 15 changed files with 35 additions and 193 deletions.
5 changes: 2 additions & 3 deletions src/model/coreDam/factory/AssetLicenceGroupFactory.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import { SYSTEM_CORE_DAM } from '@/model/systems'
import { dateTimeNow } from '@anzusystems/common-admin'
import { type DamAssetLicenceGroup, dateTimeNow } from '@anzusystems/common-admin'

Check failure on line 2 in src/model/coreDam/factory/AssetLicenceGroupFactory.ts

View workflow job for this annotation

GitHub Actions / Lint (20, ubuntu-latest)

'"@anzusystems/common-admin"' has no exported member named 'DamAssetLicenceGroup'. Did you mean 'DamAssetLicence'?
import { ENTITY } from '@/services/api/coreDam/assetLicenceGroupApi'
import type { AssetLicenceGroup } from '@/types/coreDam/AssetLicenceGroup'

export function useAssetLicenceGroupFactory() {
const createDefault = (): AssetLicenceGroup => {
const createDefault = (): DamAssetLicenceGroup => {
return {
id: 0,
name: '',
Expand Down
2 changes: 2 additions & 0 deletions src/model/coreDam/factory/UserFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export function useUserFactory() {
permissionGroups: [],
permissions: {},
resolvedPermissions: {},
licenceGroups: [],

Check failure on line 24 in src/model/coreDam/factory/UserFactory.ts

View workflow job for this annotation

GitHub Actions / Lint (20, ubuntu-latest)

Object literal may only specify known properties, and 'licenceGroups' does not exist in type 'DamUser'.
assetLicences: [],
enabled: true,
createdAt: dateTimeNow(),
Expand All @@ -43,6 +44,7 @@ export function useUserFactory() {
adminToExtSystems: user.adminToExtSystems,
userToExtSystems: [],
assetLicences: user.assetLicences,
licenceGroups: user.licenceGroups,

Check failure on line 47 in src/model/coreDam/factory/UserFactory.ts

View workflow job for this annotation

GitHub Actions / Lint (20, ubuntu-latest)

Object literal may only specify known properties, and 'licenceGroups' does not exist in type 'DamUserUpdateDto'.

Check failure on line 47 in src/model/coreDam/factory/UserFactory.ts

View workflow job for this annotation

GitHub Actions / Lint (20, ubuntu-latest)

Property 'licenceGroups' does not exist on type 'DamUser'.
allowedAssetExternalProviders: user.allowedAssetExternalProviders,
allowedDistributionServices: user.allowedDistributionServices,
}
Expand Down
14 changes: 0 additions & 14 deletions src/model/coreDam/filter/AssetLicenceGroupFilter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,3 @@ const filter = reactive({
export function useAssetLicenceGroupListFilter() {
return filter
}

export function useAssetLicenceGroupFilter() {
return reactive({
name: {
...makeFilter({ name: 'name', variant: 'startsWith' }),
},
extSystem: {
...makeFilter({ name: 'extSystem', default: null }),
},
extId: {
...makeFilter({ name: 'extId', default: null }),
},
})
}
40 changes: 7 additions & 33 deletions src/services/api/coreDam/assetLicenceGroupApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,46 +2,20 @@ import { damClient } from '@/services/api/clients/damClient'
import { SYSTEM_CORE_DAM } from '@/model/systems'
import {
apiCreateOne,
apiFetchByIds, apiFetchList,
apiFetchOne,
apiUpdateOne,
type FilterBag,
type IntegerId, type Pagination
type DamAssetLicenceGroup,

Check failure on line 7 in src/services/api/coreDam/assetLicenceGroupApi.ts

View workflow job for this annotation

GitHub Actions / Lint (20, ubuntu-latest)

'"@anzusystems/common-admin"' has no exported member named 'DamAssetLicenceGroup'. Did you mean 'DamAssetLicence'?
type IntegerId,
} from '@anzusystems/common-admin'
import type { AssetLicenceGroup } from '@/types/coreDam/AssetLicenceGroup'
import type { AxiosInstance } from 'axios'

const END_POINT = '/adm/v1/asset-licence-group'
export const ENTITY = 'assetLicenceGroup'

export const fetchAssetLicenceGroupListByIds = (client: () => AxiosInstance, ids: IntegerId[]) =>
apiFetchByIds<AssetLicenceGroup[]>(
client,
ids,
END_POINT,
{},
SYSTEM_CORE_DAM,
ENTITY,
{},
true
)
export const createAssetLicenceGroup = (data: DamAssetLicenceGroup) =>
apiCreateOne<DamAssetLicenceGroup>(damClient, data, END_POINT, {}, SYSTEM_CORE_DAM, ENTITY)

export const fetchAssetLicenceGroupList = (client: () => AxiosInstance, pagination: Pagination, filterBag: FilterBag) =>
apiFetchList<AssetLicenceGroup[]>(
client,
END_POINT,
{},
pagination,
filterBag,
SYSTEM_CORE_DAM,
ENTITY
)

export const createAssetLicenceGroup = (data: AssetLicenceGroup) =>
apiCreateOne<AssetLicenceGroup>(damClient, data, END_POINT, {}, SYSTEM_CORE_DAM, ENTITY)

export const updateAssetLicenceGroup = (id: IntegerId, data: AssetLicenceGroup) =>
apiUpdateOne<AssetLicenceGroup>(damClient, data, END_POINT + '/:id', { id }, SYSTEM_CORE_DAM, ENTITY)
export const updateAssetLicenceGroup = (id: IntegerId, data: DamAssetLicenceGroup) =>
apiUpdateOne<DamAssetLicenceGroup>(damClient, data, END_POINT + '/:id', { id }, SYSTEM_CORE_DAM, ENTITY)

export const fetchAssetLicenceGroup = (id: IntegerId) =>
apiFetchOne<AssetLicenceGroup>(damClient, END_POINT + '/:id', { id }, SYSTEM_CORE_DAM, ENTITY)
apiFetchOne<DamAssetLicenceGroup>(damClient, END_POINT + '/:id', { id }, SYSTEM_CORE_DAM, ENTITY)
4 changes: 2 additions & 2 deletions src/stores/coreDam/assetLicenceGroupStore.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { acceptHMRUpdate, defineStore } from 'pinia'
import { useAssetLicenceGroupFactory } from '@/model/coreDam/factory/AssetLicenceGroupFactory'
import type { AssetLicenceGroup } from '@/types/coreDam/AssetLicenceGroup'
import { ref } from 'vue'
import type { DamAssetLicenceGroup } from '@anzusystems/common-admin'

Check failure on line 4 in src/stores/coreDam/assetLicenceGroupStore.ts

View workflow job for this annotation

GitHub Actions / Lint (20, ubuntu-latest)

'"@anzusystems/common-admin"' has no exported member named 'DamAssetLicenceGroup'. Did you mean 'DamAssetLicence'?

export const useAssetLicenceGroupOneStore = defineStore('assetLicenceGroupOneStore', () => {
const { createDefault } = useAssetLicenceGroupFactory()

const assetLicenceGroup = ref<AssetLicenceGroup>(createDefault())
const assetLicenceGroup = ref<DamAssetLicenceGroup>(createDefault())

function reset() {
assetLicenceGroup.value = createDefault()
Expand Down
5 changes: 2 additions & 3 deletions src/stores/coreDam/userStore.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
import type { DamUser, DamUserUpdateDto } from '@anzusystems/common-admin'
import type { DamAssetLicenceGroup, DamUser, DamUserUpdateDto } from '@anzusystems/common-admin'

Check failure on line 1 in src/stores/coreDam/userStore.ts

View workflow job for this annotation

GitHub Actions / Lint (20, ubuntu-latest)

'"@anzusystems/common-admin"' has no exported member named 'DamAssetLicenceGroup'. Did you mean 'DamAssetLicence'?
import { useUserFactory } from '@/model/coreDam/factory/UserFactory'
import { acceptHMRUpdate, defineStore } from 'pinia'
import { ref } from 'vue'
import type { AssetLicenceGroup } from '@/types/coreDam/AssetLicenceGroup'

export const useUserOneStore = defineStore('damUserOneStore', () => {
const { createDefault, createDefaultForUpdate } = useUserFactory()

const user = ref<DamUser>(createDefault())
const userUpdate = ref<DamUserUpdateDto>(createDefaultForUpdate(createDefault()))
const userAssetLicenceGroups = ref<AssetLicenceGroup[]>([])
const userAssetLicenceGroups = ref<DamAssetLicenceGroup[]>([])

function setUser(userNew: DamUser) {
user.value = userNew
Expand Down
13 changes: 0 additions & 13 deletions src/types/coreDam/AssetLicenceGroup.ts

This file was deleted.

11 changes: 2 additions & 9 deletions src/views/coreDam/asset/components/ImagePreview.vue
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { computed, ref, watch } from 'vue'
import placeholder16x9 from '@/assets/image/placeholder16x9.jpg'
import { fetchImageFile } from '@/services/api/coreDam/imageApi'
import { useI18n } from 'vue-i18n'
import { useCurrentAssetLicence, useCurrentExtSystem } from '@/composables/system/currentExtSystem'
import { useCurrentAssetLicence } from '@/composables/system/currentExtSystem'
const props = withDefaults(
defineProps<{
Expand Down Expand Up @@ -47,7 +47,6 @@ const fetchImage = async (id: DocId) => {
}
const { currentAssetLicenceId } = useCurrentAssetLicence()
const { currentExtSystemId } = useCurrentExtSystem()
const imagePreviewModel = computed({
get() {
Expand Down Expand Up @@ -179,13 +178,7 @@ watch(
{{ t('system.imagePreview.actions.unassign') }}
</VBtn>
<AAssetSelect
:select-config="[
{
title: 'Default',
licence: currentAssetLicenceId,
extSystem: currentExtSystemId,
},
]"
:select-licences="[currentAssetLicenceId]"
:min-count="1"
:max-count="1"
:asset-type="AssetTypeValue.Image"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,16 @@ import {
ACreateDialog,
AFormTextField,
ARow,
ASystemEntityScope, DamAssetLicenceRemoteAutocomplete,
DamExtSystemRemoteAutocomplete
ASystemEntityScope,
type DamAssetLicenceGroup,
DamAssetLicenceRemoteAutocomplete,
DamExtSystemRemoteAutocomplete,
} from '@anzusystems/common-admin'
import { SYSTEM_CORE_DAM } from '@/model/systems'
import { useAssetLicenceGroupFactory } from '@/model/coreDam/factory/AssetLicenceGroupFactory'
import { useAssetLicenceGroupValidation } from '@/views/coreDam/assetLicenceGroup/composables/assetLicenceGroupValidation'
import { createAssetLicenceGroup, ENTITY } from '@/services/api/coreDam/assetLicenceGroupApi'
import { damClient } from '@/services/api/clients/damClient'
import type { AssetLicenceGroup } from '@/types/coreDam/AssetLicenceGroup'
withDefaults(
defineProps<{
Expand All @@ -26,11 +27,11 @@ withDefaults(
}
)
const emit = defineEmits<{
(e: 'onSuccess', data: AssetLicenceGroup): void
(e: 'onSuccess', data: DamAssetLicenceGroup): void
}>()
const { createDefault } = useAssetLicenceGroupFactory()
const assetLicenceGroup = ref<AssetLicenceGroup>(createDefault())
const assetLicenceGroup = ref<DamAssetLicenceGroup>(createDefault())
const dialog = ref(false)
const { v$ } = useAssetLicenceGroupValidation(assetLicenceGroup)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
ATableCopyIdButton,
ATableDetailButton,
ATableEditButton,
createDatatableColumnsConfig,
createDatatableColumnsConfig, type DamAssetLicenceGroup,
type DatatableOrderingOption,
useAcl,
useFilterHelpers,
Expand All @@ -22,10 +22,9 @@ import AssetLicenceGroupFilter from '@/views/coreDam/assetLicenceGroup/component
import { useAssetLicenceGroupListFilter } from '@/model/coreDam/filter/AssetLicenceGroupFilter'
import CachedExtSystemChip from '@/views/coreDam/extSystem/components/CachedExtSystemChip.vue'
import { ACL, type AclValue } from '@/types/Permission'
import type { AssetLicenceGroup } from '@/types/coreDam/AssetLicenceGroup'
import CachedAssetLicenceChip from '@/views/coreDam/assetLicence/components/CachedAssetLicenceChip.vue'
type DatatableItem = AssetLicenceGroup
type DatatableItem = DamAssetLicenceGroup
const router = useRouter()
const filter = useAssetLicenceGroupListFilter()
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,22 +1,15 @@
import { ref } from 'vue'
import type { FilterBag, IntegerId, Pagination, ValueObjectOption } from '@anzusystems/common-admin'
import { useAlerts } from '@anzusystems/common-admin'
import type { DamAssetLicenceGroup, FilterBag, Pagination } from '@anzusystems/common-admin'

Check failure on line 2 in src/views/coreDam/assetLicenceGroup/composables/assetLicenceGroupActions.ts

View workflow job for this annotation

GitHub Actions / Lint (20, ubuntu-latest)

'"@anzusystems/common-admin"' has no exported member named 'DamAssetLicenceGroup'. Did you mean 'DamAssetLicence'?
import { fetchDamAssetLicenceGroupList, useAlerts } from '@anzusystems/common-admin'

Check failure on line 3 in src/views/coreDam/assetLicenceGroup/composables/assetLicenceGroupActions.ts

View workflow job for this annotation

GitHub Actions / Lint (20, ubuntu-latest)

'"@anzusystems/common-admin"' has no exported member named 'fetchDamAssetLicenceGroupList'. Did you mean 'fetchDamAssetLicenceList'?
import { useAssetLicenceGroupOneStore } from '@/stores/coreDam/assetLicenceGroupStore'
import { storeToRefs } from 'pinia'
import {
fetchAssetLicenceGroup,
fetchAssetLicenceGroupList,
fetchAssetLicenceGroupListByIds,
updateAssetLicenceGroup,
} from '@/services/api/coreDam/assetLicenceGroupApi'
import { fetchAssetLicenceGroup, updateAssetLicenceGroup } from '@/services/api/coreDam/assetLicenceGroupApi'
import useVuelidate from '@vuelidate/core'
import { useRouter } from 'vue-router'
import { ROUTE } from '@/router/routes'
import type { AssetLicenceGroup } from '@/types/coreDam/AssetLicenceGroup'
import { useCachedAssetLicences } from '@/views/coreDam/assetLicence/composables/cachedAssetLicences'
import { useCachedExtSystems } from '@/views/coreDam/extSystem/composables/cachedExtSystems'
import { damClient } from '@/services/api/clients/damClient'
import type { AxiosInstance } from 'axios'

const { showValidationError, showRecordWas, showErrorsDefault } = useAlerts()

Expand All @@ -27,14 +20,14 @@ const saveButtonLoading = ref(false)
const saveAndCloseButtonLoading = ref(false)

export const useAssetLicenceGroupListActions = () => {
const listItems = ref<AssetLicenceGroup[]>([])
const listItems = ref<DamAssetLicenceGroup[]>([])
const { addToCachedAssetLicences, fetchCachedAssetLicences } = useCachedAssetLicences()
const { addToCachedExtSystems, fetchCachedExtSystems } = useCachedExtSystems()

const fetchList = async (pagination: Pagination, filterBag: FilterBag) => {
listLoading.value = true
try {
const res = await fetchAssetLicenceGroupList(damClient, pagination, filterBag)
const res = await fetchDamAssetLicenceGroupList(damClient, pagination, filterBag)
res.forEach((item) => {

Check failure on line 31 in src/views/coreDam/assetLicenceGroup/composables/assetLicenceGroupActions.ts

View workflow job for this annotation

GitHub Actions / Lint (20, ubuntu-latest)

Parameter 'item' implicitly has an 'any' type.
addToCachedAssetLicences(item.licences)
addToCachedExtSystems(item.extSystem)
Expand Down Expand Up @@ -137,24 +130,3 @@ export const useAssetLicenceGroupEditActions = () => {
}
}

export const useAssetLicenceGroupSelectActions = (client: () => AxiosInstance) => {
const mapToValueObjectOption = (assetLicenceGroups: AssetLicenceGroup[]): ValueObjectOption<IntegerId>[] => {
return assetLicenceGroups.map((assetLicence: AssetLicenceGroup) => ({
title: assetLicence.name,
value: assetLicence.id,
}))
}

const fetchItems = async (pagination: Pagination, filterBag: FilterBag) => {
return mapToValueObjectOption(await fetchAssetLicenceGroupList(client, pagination, filterBag))
}

const fetchItemsByIds = async (ids: number[]) => {
return mapToValueObjectOption(await fetchAssetLicenceGroupListByIds(client, ids))
}

return {
fetchItems,
fetchItemsByIds,
}
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import type { Ref } from 'vue'
import { computed } from 'vue'
import useVuelidate from '@vuelidate/core'
import { useValidate } from '@anzusystems/common-admin'
import type { AssetLicenceGroup } from '@/types/coreDam/AssetLicenceGroup'
import { type DamAssetLicenceGroup, useValidate } from '@anzusystems/common-admin'

export function useAssetLicenceGroupValidation(assetLicenceGroup: Ref<AssetLicenceGroup>) {
export function useAssetLicenceGroupValidation(assetLicenceGroup: Ref<DamAssetLicenceGroup>) {
const { required, minLength, minValue } = useValidate()

const rules = computed(() => ({
Expand Down
Loading

0 comments on commit 1cc7191

Please sign in to comment.