Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoConnect function to standard adapter #8

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mcintyre94
Copy link
Collaborator

@mcintyre94 mcintyre94 commented Dec 22, 2022

This PR refactors out the adapter connect function into a private #connect, which takes a silent flag and passes it through to the wallet connect function

We add a new autoConnect function which passes silent: true. This will be used by wallet-adapter automatically whenever the wallet is automatically connected on a page load.

@jordansexton

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2022

🦋 Changeset detected

Latest commit: 2dc02bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@solana/wallet-standard-wallet-adapter-base Minor
@solana/wallet-standard-wallet-adapter Patch
@solana/wallet-standard-wallet-adapter-react Patch
@solana/wallet-standard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcintyre94 mcintyre94 marked this pull request as draft December 23, 2022 10:43
@mcintyre94
Copy link
Collaborator Author

Marking this a draft for now. Both Glow and Backpack have issues with being called like this which will need to be resolved before we make this change

  • In Backpack, Connect and then Autoconnect (eg refresh the page) causes a WalletAccountError
  • In Glow, Connect, Disconnect, Connect, Autoconnect causes a WalletConnectionError: This address is not connected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant