-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds accounts lt hash featurization #3334
Conversation
847a7fe
to
4c27110
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the plan for feature enable lt hash?
replace EAH?
Yep! This feature gate does two things:
|
Can we add this #3334 (comment) to the feature code comments? |
Yes! Thank you, I forgot about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Code at time of review is missing features
I've dismissed the current reviews and moved this PR back to a draft. I need to implement calculating the accounts lt hash at feature activation time too, which was missing. After implementation and testing, I'll re-request reviews. Thanks for bearing with me here. |
1488222
to
f3c1449
Compare
f3c1449
to
c243c01
Compare
I made a first pass review of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Problem
The accounts lt hash must be enabled cluster-wide, so it requires a feature gate. There currently isn't one.
Summary of Changes
Feature Gate Issue: #3333