Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0: CI: Disable downstream anchor builds (backport of #2629) #2647

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 17, 2024

Problem

With solana-labs/solana-program-library#7148, spl-token-2022 has moved from using solana-zk-token-sdk to solana-zk-sdk, which is a major breaking change. Certain agave and anchor crates are depending on the re-export solana-zk-token-sdk in spl-token-2022, which is no longer present. This change is causing the downstream Anchor job to fail, since the patched version of spl-token-2022 is no longer compatible.

Summary of changes

Until new major versions of the SPL crates are available used by the Agave monorepo, disable the downstream anchor job.


This is an automatic backport of pull request #2629 done by Mergify.

#### Problem

With solana-labs/solana-program-library#7148,
spl-token-2022 has moved from using solana-zk-token-sdk to
solana-zk-sdk, which is a major breaking change. Certain agave and
anchor crates are depending on the re-export solana-zk-token-sdk in
spl-token-2022, which is no longer present. This change is causing the
downstream Anchor job to fail, since the patched version of
spl-token-2022 is no longer compatible.

#### Summary of changes

Until new major versions of the SPL crates are available used by the
Agave monorepo, disable the downstream anchor job.

(cherry picked from commit 3b9e7a3)

# Conflicts:
#	.github/workflows/downstream-project-anchor.yml
@mergify mergify bot added the conflicts label Aug 17, 2024
@mergify mergify bot requested a review from a team as a code owner August 17, 2024 13:12
Copy link
Author

mergify bot commented Aug 17, 2024

Cherry-pick of 3b9e7a3 has failed:

On branch mergify/bp/v2.0/pr-2629
Your branch is up to date with 'origin/v2.0'.

You are currently cherry-picking commit 3b9e7a3ca5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/downstream-project-anchor.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@joncinque joncinque merged commit 600cfbb into v2.0 Aug 17, 2024
17 checks passed
@joncinque joncinque deleted the mergify/bp/v2.0/pr-2629 branch August 17, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants