Brevo: Rename SendinBlue to Brevo #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace "SendinBlue" with "Brevo" throughout the code. - Maintain deprecated compatibility versions on the old names/URLs. (Split into separate commit to make renamed files more obvious.) - Update docs to reflect change, provide migration advice. - Update integration workflow.
(See previous commit.) - Maintain deprecated compatibility versions on the old names/URLs. (Split into separate commit to make renamed files more obvious.)
medmunds
force-pushed
the
feature/rename-sendinblue
branch
from
419c40a to
948ab2b
Compare
|
[Split into two commits, which makes it possible to see the actual diffs in the renamed files before adding the compatibility versions on the original filenames: backends/sendinblue.py → backends/brevo.py; webhooks/sendinblue.py → webhooks/brevo.py] |
|
(Released in Anymail 10.3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been rethinking my arguments in #321 about leaving "SendinBlue" in the code while calling it "Brevo" everywhere else. I now feel this creates more confusion (particularly with new users) than it avoids.
This PR renames "sendinblue" to "brevo" throughout the code, but maintains compatibility versions on the old names and URLs (with deprecation warnings).
The compatibility versions use the old
esp_name, which means that settings names and other related features are also unchanged. So if you haveEMAIL_BACKEND = "…sendinblue.EmailBackend", Anymail will continue to look forSENDINBLUE_API_KEYin the settings. But when you update toEMAIL_BACKEND = "…brevo.EmailBackend", you'll need to switch toBREVO_API_KEYat the same time.I don't have any particular schedule for removing the deprecated compatibility versions. (They don't really add maintenance overhead.)