Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some issue #2472

Merged
merged 4 commits into from
Aug 8, 2022
Merged

fix: fix some issue #2472

merged 4 commits into from
Aug 8, 2022

Conversation

NewByVector
Copy link
Contributor

Description

Close #2465
Close #2466
Close #2464

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added pkg:x6 PR: unreviewed PR does not have any reviews. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2817841457

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 2816600231: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #2472 (92d108e) into master (59fb1d2) will not change coverage.
The diff coverage is 12.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2472   +/-   ##
=======================================
  Coverage   40.83%   40.83%           
=======================================
  Files         542      542           
  Lines       32334    32334           
  Branches     6585     6585           
=======================================
  Hits        13205    13205           
  Misses      18337    18337           
  Partials      792      792           
Flag Coverage Δ
x6 26.93% <12.50%> (ø)
x6-geometry 63.74% <ø> (ø)
x6-vector 94.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/x6/src/addon/selection/index.ts 13.92% <ø> (ø)
packages/x6/src/graph/renderer.ts 9.26% <ø> (ø)
packages/x6/src/model/edge.ts 20.07% <ø> (ø)
packages/x6/src/model/model.ts 10.10% <12.50%> (ø)

@NewByVector NewByVector merged commit 4ffb619 into master Aug 8, 2022
@NewByVector NewByVector deleted the vector.dev branch August 8, 2022 12:34
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged PR has merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
2 participants