libgccjit: Allow sending a const pointer as argument #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoyo
added
the
waiting for review
|
I've commented on the ML here: https://gcc.gnu.org/pipermail/jit/2024q4/001941.html |
antoyo
added
waiting on author
and removed
waiting for review
gcc/jit/ChangeLog: * jit-recording.h: Remove memento_of_get_const::accepts_writes_from, memento_of_get_type::is_same_type_as: new method. gcc/testsuite/ChangeLog: * jit.dg/all-non-failing-tests.h: Add test-const-pointer-argument.c. * jit.dg/test-const-pointer-argument.c: New test.
antoyo
force-pushed
the
const-pointer-argument
branch
from
7a57f72 to
f8ae821
Compare
|
@davidmalcolm: Thanks for the review. I updated the test so that it makes more sense and reflect the bug I actually have: I needed to add an implementation of is_same_type_as to make it work. I do not know how to keep the type safety, though, as the same code is used for assignements (where we would not want to assign to a const) and parameters (where we can send a const argument). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ML Link: https://gcc.gnu.org/pipermail/jit/2023q4/001759.html
gcc/jit/ChangeLog:
gcc/testsuite/ChangeLog: