v24.10

.clang-tidy

@@ -1,13 +1,14 @@
 ---
 Checks:
   '-*,
-  modernize-avoid-c-arrays,
   modernize-loop-convert,
   modernize-make-shared,
   modernize-make-unique,
   modernize-use-bool-literals,
   modernize-use-default-member-init,
   modernize-use-emplace,
+  modernize-use-equals-default,
+  modernize-use-equals-delete,
   modernize-use-nullptr,
   modernize-use-override,
   modernize-use-std-print,
@@ -22,7 +23,19 @@ Checks:
   performance-trivially-destructable,
   performance-unnecessary-copy-initialization,
   performance-unnecessary-value-param,
-  readability-uppercase-literal-suffix'
+  readability-container-contains,
+  readability-duplicate-include,
+  readability-else-after-return,
+  readability-redundant-casting,
+  readability-redundant-control-flow,
+  readability-redundant-member-init,
+  readability-redundant-string-cstr,
+  readability-redundant-string-init,
+  readability-reference-to-constructed-temporary,
+  readability-simplify-boolean-expr,
+  readability-string-compare,
+  readability-uppercase-literal-suffix,
+  readability-use-std-min-max'
 
 WarningsAsErrors: '*'
 

.gersemirc

@@ -0,0 +1 @@
+# Gersemi configurationcolor: falsedefinitions: []indent: 2line_length: 80quiet: falseunsafe: false

.github/workflows/ci-msw.yml

@@ -0,0 +1,46 @@
+name: github-ci-msw
+
+on: [push]
+
+jobs:
+  build:
+    # https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md
+    runs-on: windows-latest
+
+    strategy:
+      fail-fast: false
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          submodules: 'recursive'
+
+      - name: Install boost
+        uses: MarkusJx/[email protected]
+        id: install-boost
+        with:
+          # REQUIRED: Specify the required boost version
+          # A list of supported versions can be found here:
+          # https://github.com/actions/boost-versions/blob/main/versions-manifest.json
+          boost_version: 1.83.0
+
+      - name: Add msbuild
+        uses: microsoft/setup-msbuild@v2
+
+      - name: Configure
+        shell: pwsh
+        run: |
+          .\build-gen.ps1 -boost_dir ${{steps.install-boost.outputs.BOOST_ROOT}} -tests -prepare
+
+      - name: Build
+        working-directory: build
+        run: |
+          msbuild /noLogo /m /p:Configuration=Release ALL_BUILD.vcxproj
+
+      - name: Run tests
+        uses: threeal/[email protected]
+        with:
+          build-config: Release
+          tests-regex: or
+          verbose: true

.github/workflows/ccpp.yml → .github/workflows/ci-ubuntu.yml

@@ -1,4 +1,5 @@
-name: github-ci
+name: github-ci-ubuntu
+
 on: [push]
 
 jobs:
@@ -24,10 +25,13 @@ jobs:
           platform_version: 20.04
 
       - name: Install gtk
-        run: sudo apt-get update && sudo apt-get install liblzma5 libjbig0 libgtk-3-dev
+        run:
+          sudo apt-get update -qq &&
+          sudo apt-get install liblzma5 libjbig0 libgtk-3-dev
 
-      - name: Install gcc, lcov, gdb
-        run: sudo apt-get install -yq gcc-13 g++-13 lcov gdb
+      - name: Install gcc, lcov, gdb, theme-icon
+        # gcov uses similar version, see build-gen.sh -c
+        run: sudo apt-get install -yq gcc-12 g++-12 lcov gdb yaru-theme-icon
 
       - name: Install xvfb to allow headless tests
         run: sudo apt-get install xvfb
@@ -47,8 +51,8 @@ jobs:
         run: ./build-gen.sh -b -c -g -p -t -B ${{steps.install-boost.outputs.BOOST_ROOT}}
         env:
           BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }}
-          CC: gcc-13
-          CXX: g++-13
+          CC: gcc-12
+          CXX: g++-12
 
       - name: Make using ninja
         run: cd build && ninja
@@ -58,6 +62,8 @@ jobs:
           ninja lcov-prep &&
           xvfb-run --auto-servernum ctest -VV &&
           ninja lcov
+        env:
+          NO_AT_BRIDGE: 1
 
       - name: Coveralls
         run: cd build && coveralls -r 9vV6skuIGeagBBkz5TCZNI12ezUv12gOj --format=lcov --file=src/app.run

.gitignore

@@ -1,3 +1,4 @@
 build/
+swig/
 *.html
 *.xml

CHANGELOG.md

@@ -4,7 +4,46 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
-## 24.04 - 2024-04-01 [Unreleased]
+## 24.10 - 2024-09-22
+
+### Added
+
+- added msw build script build-gen.ps1 for building wex on windows
+- gersemi support, and wex cmake code follows these guidelines
+- right click on File Type enables or disables showing whitespace
+- Go lexer
+- a WIN_SINGLE_LINE to data::stc, used in e.g. stc_entry_dialog
+- factory::vcs and support exclude find in git submodules
+
+### Changed
+
+- upgrade to lexilla 5.3.1
+- updated art default bitmap colour
+- hexmode insert or erase keeps position
+- clang-tidy updated
+- renamed FindWEX into Findwex and supports adding a version
+- used wrapline none for rfw lexer
+- moved vcs_admin to factory lib
+- renamed frame::is_address into vi_is_address and frame::exec_ex_command into
+  vi_exec_command
+- boost::process::v2 lib used for find_executable
+- used small browse buttons in dialogs
+
+### Fixed
+
+- ex mode find and getting previous line
+- any file used for config uses json lexer
+- fixed a possible filename too long exception when trying opening links
+- show error if no macros present for a lexer
+- improved cleaning when history view is closed
+- register calculator used in insert mode
+- reporting matches when doing replace in files
+- handling shift home, end key in command-line
+- initializing item combobox with empty value, and file pickerctrl
+  can be initialized with executable
+- ex global command and append or change of insert
+
+## 24.04 - 2024-03-29
 
 ### Added
 
@@ -40,7 +79,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 ### Added
 
 - wex-test lib
-- python bindings
+- python bindings using swig
 
 ### Changed
 

CMakeLists.txt

@@ -2,107 +2,142 @@ cmake_minimum_required(VERSION 3.21)
 
 project(wex)
 
-if (wexBUILD_SHARED)
+if(wexBUILD_SHARED)
   set(BUILD_SHARED_LIBS YES)
   set(wxBUILD_SHARED ON)
   add_definitions(-DBOOST_LOG_DYN_LINK)
-  
+
   if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
-    set(CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS 
-      "${CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS} -undefined dynamic_lookup")
+    set(
+      CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS
+      "${CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS} -undefined dynamic_lookup"
+    )
   endif()
-else ()
+else()
   set(Boost_USE_STATIC_LIBS ON)
   set(wxBUILD_SHARED OFF)
-endif ()
-  
-if (wexBUILD_GITHUB)
+endif()
+
+if(wexBUILD_GITHUB)
   add_definitions(-DGITHUB)
-endif ()
+endif()
 
-if (APPLE)
+if(APPLE)
   find_package(LLVM REQUIRED CONFIG)
-endif ()
+endif()
 
 set(Boost_USE_MULTITHREADED ON)
 set(Boost_USE_STATIC_RUNTIME OFF)
 set(CMAKE_DISABLE_PRECOMPILE_HEADERS ON)
 
-find_package(Boost 1.81.0 COMPONENTS 
-  log_setup log filesystem program_options date_time regex json url REQUIRED)
-
+find_package(
+  Boost
+  1.81.0
+  COMPONENTS log_setup log filesystem program_options date_time regex json url
+  REQUIRED
+)
+
 set(user $ENV{USER} CACHE INTERNAL "keep user")
 
 include(cmake/options-wx.cmake)
 
 execute_process(
   COMMAND git apply ${CMAKE_SOURCE_DIR}/external/wxWidgets.patch
-  WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/external/wxWidgets)
+  WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/external/wxWidgets
+)
 
 execute_process(
   COMMAND git apply ${CMAKE_SOURCE_DIR}/external/lexilla.patch
-  WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/external/wxWidgets/src/stc/lexilla)
+  WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/external/wxWidgets/src/stc/lexilla
+)
 
 include_directories(${Boost_INCLUDE_DIRS})
 include_directories(external/doctest/doctest)
 
+set(
+  CMAKE_MODULE_PATH
+  "${CMAKE_SOURCE_DIR}/external/wxWidgets/build/cmake/modules"
+)
+
 add_subdirectory(external)
 
 include(external/wxWidgets/build/cmake/toolkit.cmake)
 
 file(READ src/core/version.cpp WEX_VERSION_CONTENTS)
-string(REGEX MATCH "[ \t]+([0-9]+),[ \t\n]*([0-9]+),[ \t\n]*([0-9]+)"
-  WEX_VERSION ${WEX_VERSION_CONTENTS})
+string(
+  REGEX MATCH
+  "[ \t]+([0-9]+),[ \t\n]*([0-9]+),[ \t\n]*([0-9]+)"
+  WEX_VERSION
+  ${WEX_VERSION_CONTENTS}
+)
 set(WEX_VERSION ${CMAKE_MATCH_1}.${CMAKE_MATCH_2}.${CMAKE_MATCH_3})
 set(WEX_VERSION_INCLUDE ${CMAKE_MATCH_1}.${CMAKE_MATCH_2})
-string(REGEX MATCH "\".c.[ 0-9a-zA-Z,.\-]+\""
-  WEX_COPYRIGHT ${WEX_VERSION_CONTENTS})
+string(
+  REGEX MATCH
+  "\".c.[ 0-9a-zA-Z,.\-]+\""
+  WEX_COPYRIGHT
+  ${WEX_VERSION_CONTENTS}
+)
 set(WEX_COPYRIGHT ${WEX_COPYRIGHT})
 
-if (wexENABLE_GETTEXT)
+if(wexENABLE_GETTEXT)
   include(FindGettext)
-endif ()
+endif()
 
-if (wexENABLE_ODBC)
+if(wexENABLE_ODBC)
   find_package(ODBC)
-endif ()
+endif()
 
 enable_testing()
 
-set (CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/external/wxWidgets/build/cmake/modules")
-
 include(cmake/options.cmake)
 include(cmake/common.cmake)
 
-if (wexENABLE_ASAN)
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address -fno-omit-frame-pointer")
+if(wexENABLE_ASAN)
+  set(
+    CMAKE_CXX_FLAGS
+    "${CMAKE_CXX_FLAGS} -fsanitize=address -fno-omit-frame-pointer"
+  )
   set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fsanitize=address")
-endif ()
-
-# See also FindWEX
-set(wex_own_LIBRARIES
-  wex-del wex-vcs wex-stc wex-vi wex-ex wex-ctags
-  wex-ui wex-common wex-data wex-syntax wex-factory wex-test wex-core)
+endif()
+
+# See also Findwex
+set(
+  wex_own_LIBRARIES
+  wex-del
+  wex-vcs
+  wex-stc
+  wex-vi
+  wex-ex
+  wex-ctags
+  wex-ui
+  wex-common
+  wex-data
+  wex-syntax
+  wex-factory
+  wex-test
+  wex-core
+)
 
 separate_arguments(wex_own_LIBRARIES)
 
-set(WEX_CXX_STANDARD 23) # see also FindWEX.cmake, c_cpp_properties.json
+set(WEX_CXX_STANDARD 23) # see also Findwex.cmake, c_cpp_properties.json
 set(CMAKE_CXX_STANDARD ${WEX_CXX_STANDARD})
 
 add_subdirectory(ci)
 add_subdirectory(src)
 
-if (wexBUILD_BINDINGS)
+if(wexBUILD_BINDINGS)
   add_subdirectory(bindings)
-endif ()
+endif()
 
-if (wexBUILD_SAMPLES)
+if(wexBUILD_SAMPLES)
   add_subdirectory(sample)
-endif ()
+endif()
 
-if (wexBUILD_TESTS)
+if(wexBUILD_TESTS)
   add_subdirectory(test)
-endif ()
+endif()
 
 add_subdirectory(locale)
 

CONTRIBUTING.md

@@ -10,9 +10,13 @@
 
 - use style as indicated by .clang-format
 
+- use cmake file style as indicated by
+  [gersemi](https://github.com/blankspruce/gersemi)
+
 - use STL whenever possible
 
 - doxy document sources
+
   API documentation is generated from the sources
   using [Doxygen](http://www.stack.nl/~dimitri/doxygen/)
 
@@ -54,7 +58,7 @@ ninja analyse
 - test coverage can be generated by add -c switch to build-gen
   This requires `lcov` and `genhtml` tools (part of lcov).
   Also, when pushing commits, test coverage is done automatically using
-  the GitHub workflow ccpp.yml.
+  the GitHub workflow ci-ubuntu.yml.
 
 ```bash
 ./build-gen.sh -c -t