Fix doctests for pari 2.17 on 32-bit #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@antonio-rojas here is a patch for 32 bits that you can merge into sagemath#38749.
Starting with pari 2.17 the default bit precision is 128 regardless of
BITS_IN_LONG(previously it was 128 for 64-bit but only 96 for 32-bit).This commit replaces instances of tests with two outputs labeled
# 64-bitand# 32-bitby a single one without label.There is an exception with
elleta()which stems from a (bug? weird?) upstream behaviour (nothing to do with pari 2.17).Also the doctest to test the
# 64-bitand# 32-bitlabels had to be changed to something else.