Bump third_party/pigweed/repo from 9e4bfb9 to e765c4d (project-ch…

…ip#29314)

* Bump third_party/pigweed/repo from `9e4bfb9` to `e765c4d`

Bumps [third_party/pigweed/repo](https://github.com/google/pigweed) from `9e4bfb9` to `e765c4d`.
- [Commits](google/pigweed@9e4bfb9...e765c4d)

---
updated-dependencies:
- dependency-name: third_party/pigweed/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Make gdbus compilation not fail on unreachable code

* Restyle

* Skip clang-tidy on java codegen files since it is very slow (lots of templates) and it is generated code without actual changes in general

* Skip the new missing default case bugprone as too many hits currently

* Remove one more bugprone check - very hard to meet with templates and char** to void* conversions

* Exclude one more bugprone: it is complaining about valid code in TestReportingEngine and I could find no way to actually fix it

* Fix regex for exclusion for clang-tidy

* Fix some clang-tidy complains

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrei Litvin <[email protected]>

.clang-tidy

@@ -10,20 +10,23 @@ Checks: >
   readability-redundant-control-flow,
   readability-redundant-string-cstr,
   readability-redundant-string-init,
-  -bugprone-assignment-in-if-condition,  
+  -bugprone-assignment-in-if-condition,
   -bugprone-branch-clone,
   -bugprone-copy-constructor-init,
   -bugprone-easily-swappable-parameters,
   -bugprone-forward-declaration-namespace,
   -bugprone-forwarding-reference-overload,
   -bugprone-implicit-widening-of-multiplication-result,
+  -bugprone-inc-dec-in-conditions,
   -bugprone-macro-parentheses,
   -bugprone-misplaced-widening-cast,
+  -bugprone-multi-level-implicit-pointer-conversion,
   -bugprone-narrowing-conversions,
   -bugprone-not-null-terminated-result,
   -bugprone-reserved-identifier,
   -bugprone-signed-char-misuse,
   -bugprone-suspicious-include,
+  -bugprone-switch-missing-default-case,
   -bugprone-undelegated-constructor,
   -bugprone-unused-return-value,
   -clang-analyzer-core.CallAndMessage,

.github/workflows/build.yaml

@@ -200,7 +200,7 @@ jobs:
                   ./scripts/run_in_build_env.sh \
                     "./scripts/run-clang-tidy-on-compile-commands.py \
                        --compile-database out/sanitizers/compile_commands.json \
-                       --file-exclude-regex '/(repo|zzz_generated|lwip/standalone)/' \
+                       --file-exclude-regex '/(repo|zzz_generated|lwip/standalone)/|-ReadImpl|-InvokeSubscribeImpl' \
                        check \
                     "
             - name: Clean output

build/chip/linux/gdbus_library.gni

@@ -35,6 +35,12 @@ template("gdbus_library") {
     include_dirs = [ "${root_gen_dir}/include" ]
   }
 
+  config("${library_name}_compile_config") {
+    # dbus code generation may generate some code detected as unreacheable
+    # by recent enough clang
+    cflags = [ "-Wno-unreachable-code" ]
+  }
+
   dbus_sources = []
   foreach(xml, invoker.sources) {
     name = get_path_info(xml, "name")
@@ -94,6 +100,7 @@ template("gdbus_library") {
     sources = dbus_sources
     deps = [ ":${library_name}_gen" ]
 
+    configs += [ ":${library_name}_compile_config" ]
     public_configs = [
       ":${library_name}_config",
       glib_config,

src/controller/java/AndroidDeviceControllerWrapper.cpp

@@ -403,8 +403,8 @@ CHIP_ERROR AndroidDeviceControllerWrapper::ApplyNetworkCredentials(chip::Control
         passwordStr = static_cast<jstring>(env->NewGlobalRef(env->CallObjectMethod(wifiCredentialsJava, getPassword)));
         VerifyOrReturnError(ssidStr != nullptr && !env->ExceptionCheck(), CHIP_JNI_ERROR_EXCEPTION_THROWN);
 
-        ssid                 = env->GetStringUTFChars(ssidStr, 0);
-        password             = env->GetStringUTFChars(passwordStr, 0);
+        ssid                 = env->GetStringUTFChars(ssidStr, nullptr);
+        password             = env->GetStringUTFChars(passwordStr, nullptr);
         jsize ssidLength     = env->GetStringUTFLength(ssidStr);
         jsize passwordLength = env->GetStringUTFLength(passwordStr);
 
@@ -601,7 +601,7 @@ void AndroidDeviceControllerWrapper::OnScanNetworksSuccess(
     std::string NetworkingStatusCtorSignature = "(I)V";
     jint jniNetworkingStatus                  = static_cast<jint>(dataResponse.networkingStatus);
     chip::JniReferences::GetInstance().CreateBoxedObject<jint>(
-        NetworkingStatusClassName.c_str(), NetworkingStatusCtorSignature.c_str(), jniNetworkingStatus, NetworkingStatus);
+        NetworkingStatusClassName, NetworkingStatusCtorSignature, jniNetworkingStatus, NetworkingStatus);
     jobject DebugText;
     if (!dataResponse.debugText.HasValue())
     {
@@ -633,8 +633,8 @@ void AndroidDeviceControllerWrapper::OnScanNetworksSuccess(
             std::string newElement_securityClassName     = "java/lang/Integer";
             std::string newElement_securityCtorSignature = "(I)V";
             jint jniNewElementSecurity                   = static_cast<jint>(entry.security.Raw());
-            chip::JniReferences::GetInstance().CreateBoxedObject<jint>(newElement_securityClassName.c_str(),
-                                                                       newElement_securityCtorSignature.c_str(),
+            chip::JniReferences::GetInstance().CreateBoxedObject<jint>(newElement_securityClassName,
+                                                                       newElement_securityCtorSignature,
                                                                        jniNewElementSecurity, newElement_security);
             jobject newElement_ssid;
             jbyteArray newElement_ssidByteArray = env->NewByteArray(static_cast<jsize>(entry.ssid.size()));