Clang tidy uninitialized.Branch (project-chip#17647)

* Clang tidy uninitialized.Branch * Do not link Optional.h as the destructor code seems to be too tricky for the linter
antonio-amjr · Apr 25, 2022 · c292484 · c292484
1 parent d9ad275
commit c292484
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -26,7 +26,6 @@ Checks: >
   -clang-analyzer-core.UndefinedBinaryOperatorResult,
   -clang-analyzer-core.NullDereference,
   -clang-analyzer-optin.cplusplus.UninitializedObject,
-  -clang-analyzer-core.uninitialized.Branch,
   -clang-analyzer-optin.performance,
   -clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker,
   -clang-analyzer-deadcode.DeadStores,

diff --git a/src/app/util/ember-compatibility-functions.cpp b/src/app/util/ember-compatibility-functions.cpp
@@ -576,7 +576,7 @@ CHIP_ERROR ReadSingleClusterData(const SubjectDescriptor & aSubjectDescriptor, b
             (attributeCluster != nullptr) ? &reader : GetAttributeAccessOverride(aPath.mEndpointId, aPath.mClusterId);
         if (attributeOverride)
         {
-            bool triedEncode;
+            bool triedEncode = false;
             ReturnErrorOnFailure(ReadViaAccessInterface(aSubjectDescriptor.fabricIndex, aIsFabricFiltered, aPath, aAttributeReports,
                                                         apEncoderState, attributeOverride, &triedEncode));
             ReturnErrorCodeIf(triedEncode, CHIP_NO_ERROR);

diff --git a/src/lib/core/Optional.h b/src/lib/core/Optional.h
@@ -50,6 +50,7 @@ class Optional
 
     ~Optional()
     {
+        // NOLINTNEXTLINE(clang-analyzer-core.uninitialized.Branch): mData is set when mHasValue
         if (mHasValue)
         {
             mValue.mData.~T();