Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add unit tests #461

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

chore: Add unit tests #461

wants to merge 3 commits into from

Conversation

MaxymVlasov
Copy link
Collaborator

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

Description of your changes

Closes #303

How can we test changes

  1. Download shunit2 from https://github.com/kward/shunit2
  2. Add shunit2 to PATH
  3. cd to pre-commit-terraform/tests/shunit2
  4. Run ./_common_test.sh

@MaxymVlasov MaxymVlasov changed the title Add unit tests chore: Add unit tests Jan 27, 2023
@MaxymVlasov MaxymVlasov changed the title chore: Add unit tests tests: Add unit tests Jan 27, 2023
@MaxymVlasov MaxymVlasov changed the title tests: Add unit tests chore: Add unit tests Jan 27, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2023
@MaxymVlasov MaxymVlasov removed the stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 30, 2023
@MaxymVlasov MaxymVlasov removed the stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 30, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 30, 2023
@MaxymVlasov MaxymVlasov added wip Indicates that an issue or PR is actively being worked on by a contributor. and removed stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yermulnik yermulnik Awaiting requested review from yermulnik yermulnik will be requested when the pull request is marked ready for review yermulnik is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
wip Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit-tests that will found problems with new code
1 participant
@MaxymVlasov