-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tests in kona-mpt
#738
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
hi, this is my first PR here, so please let me know if anything is wrong 🙏 |
Unsure as to where there are compilation errors. Do you have a command I can reproduce that causes the |
hey @refcell
full log:
|
Thanks @steph-rs for clarifying, I'm seeing the same issue for benches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
This PR resolves compilation issues in the
kona-mpt
crate by addingreqwest
feature, and other small fixes