feat(host): kzg proof for blobs #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
clabby
approved these changes
Jul 11, 2024
|
Issue is already there. It’s linked in this PR description (#369).
…On Thu, Jul 11, 2024 at 8:00 AM clabby ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM. Before merging, can we please put up an issue to further abstract
the host? This extra piece of data eventually should be able to be added by
you guys downstream.
—
Reply to this email directly, view it on GitHub
<#370 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABL3ULG4X5OIOZT7GSK5JT3ZL2MXPAVCNFSM6AAAAABKWH3VZSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZSGE2TCOBQGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when the fetcher gathers blob data, it saves the preimages for each element in the blob, but does not save the KZG proof (because it is not needed in FPVM context). However, in the ZKVM context, we need this information.
This PR creates a short term workaround to save the kzg proof as a psuedo element 4096 in the Blob type (since the blob only uses elements 0 to 4095 inclusive).
For a longer term fix, I've opened this ticket for a feature to override fetcher implementations: #369
Tests
N/A
Additional context
N/A
Metadata
N/A