Refine the formatting of generated Python3 code #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelson
changed the title
pelson
commented
Oct 1, 2024
| @@ -829,7 +874,7 @@ class <lexer.name>(<if(superClass)><superClass><else>Lexer<endif>): | |||
| SerializedATN(model) ::= << | |||
| def serializedATN(): | |||
| return [ | |||
| <model.serialized: {s | <s>}; separator=",", wrap> | |||
| <model.serialized: {s | <s>}; separator=", ", wrap> | |||
There was a problem hiding this comment.
I found this rule to be close to what I wanted, except that there remains a trailing whitespace when a line is wrapped. I didn't know how to fix this, and figured it was good enough for now.
pelson
force-pushed
the
feature/py-generator-enh
branch
from
2da4d34 to
7a89e15
Compare
|
Thanks for this but it breaks the build |
pelson
force-pushed
the
feature/py-generator-enh
branch
from
30218cd to
b5e3997
Compare
|
Hi, looks like you need to rebase this PR ? |
Signed-off-by: Phil Elson <[email protected]>
Signed-off-by: Phil Elson <[email protected]>
pelson
force-pushed
the
feature/py-generator-enh
branch
from
b5e3997 to
bb10cd6
Compare
Yes, it was related to #4726 which touched some code that got removed in this PR. Should be all fixed. |
Signed-off-by: Phil Elson <[email protected]>
pelson
force-pushed
the
feature/py-generator-enh
branch
from
9b484f6 to
ac3fe8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles mostly whitespace improvement to be more aligned with PEP-8 by default. It doesn't yet fix a number of the newline issues that crop up.
Additionally, it improves the typing of a number of obvious methods. The typing remains incomplete however.
The changes to
XPathLexer.pyare fully auto-generated (with the exception of thecheckVersioncall).In the future, I would work towards removing the
from antlr4 import *and replacing it with named imports.I have validated this against a mildly complex parser grammar in https://github.com/SciTools/cf-units/blob/main/cf_units/_udunits2_parser/udunits2Parser.g4.