Make slackistrano optional

[gido]

💬 Describe the pull request

What if I don't want slackistrano ?

[gido]

I suppose this break BC but slackistrano should be optional

[yannlugrin]

We could keep the gem dependency as that doesn't have so much effect. But if you want to remove it, why not.

[yannlugrin]

Maybe this file should be removed because even styleguide is optional.

[gido]

I agree. But this will be a BC break, no?

[yannlugrin]

it's a breaking change if you update the module on a project, but also an easy fix.

[yannlugrin]

And that will probably not break the build, just stop to send notifications. Also, the dependency was removed from gemspec, so makes no sense to have this here.

[gido]

OK, the Gemfile.lock works as expected (https://github.com/antistatique/cardis-server/blob/dev/Gemfile.lock#L2-L3)

Is the [0.1.0](https://github.com/antistatique/cardis-server/blob/dev/Gemfile#L7) doing something useful in the case of a reference to a git ?

[yannlugrin]

No, it's useless

[yannlugrin]

The only case that must be specified if not gem spec exist in the repository if I remember correctly

[yannlugrin]

We could keep the gem dependency as that doesn't have so much effect. But if you want to remove it, why not.

[yannlugrin]

@gido About that, i think we should remove everything from lib/capistrano/antistatique.rb and let load what we need in each project. We could just print a message that tells the user to update the requirements in Capfile.

Do you agree with that?

[gido]

@gido About that, i think we should remove everything from lib/capistrano/antistatique.rb and let load what we need in each project. We could just print a message that tells the user to update the requirements in Capfile.

Do you agree with that?

Yes. I'm in favor to cherry-pick for each project which recipes we need.