-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set _NET_WM_NAME so that the window can be shared on screen-sharing software #31
base: master
Are you sure you want to change the base?
Conversation
Gstreamer does not set the _NET_WM_NAME property on the window it creates when using `autovideosink` (or ximagesink/xvimagesink for that matter). A lot of tools (like Zoom) filter based on this field being non-null, so the window can't be shared. This horrible hack finds the first open window that matches our application name and proceeds to set _NET_WM_NAME on it. It is very ugly, but it works.
I tested your code and confirm it works nicely on Zoom! Thanks! |
I tested it and in Discord it worked without this. Nevertheless I backported it to my AUR package in this commit Sadly this project seems kinda dead so if someone wants to actively maintain a fork I may switch to it. |
renamed to UxPlay |
The solution would be very useful not only for Zoom users but also for BBB users. Unfortunately, I'm not a developer. I tried to compile the code from DavidVentura, but with no visible success. The window is already noname. Maybe I forget something important? Excuse for probably very boring question: I changed the two files mentioned here: 7c80c93 and run cmake, make. It compiles and working fine. But still no window name ... Seems to be, there is a step missing? Would be happy, if someone could help! |
To verify if the window is your problem, you can set a name manually: my patch does that (and it's also upstreamed). i guess you just have some cache? either delete your repo and clone+build again or do some type of |
I can confirm that this patch works great.
with it, Zoom finds the window.
… On Mar 8, 2021, at 10:26 AM, Peter111160 ***@***.***> wrote:
The solution would be very useful not only for Zoom users but also for BBB users. Unfortunately, I'm not a developer. I tried to compile the code from DavidVentura, but with no visible success. The window is already noname. Maybe I forget something important? Excuse for probably very boring question: I changed the two files mentioned here: 7c80c93 <7c80c93> and run cmake, make. It compiles and working fine. But still no window name ... Seems to be, there is a step missing? Would be happy, if someone could help!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#31 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARKXYDOV6DLBWUCGGL7ODWDTCTUBFANCNFSM4WNVENJQ>.
|
|
…en-sharing software #31 (added fix from PR #3 from https://github.com/DavidVentura/UxPlay) Gstreamer does not set the _NET_WM_NAME property on the window it creates when using autovideosink (or ximagesink/xvimagesink for that matter). A lot of tools (like Zoom) filter based on this field being non-null, so the window can't be shared. This horrible hack finds the first open window that matches our application name and proceeds to set _NET_WM_NAME on it. It is very ugly, and I do not know what I am doing, but it works. Feel free to use this to write something that makes more sense. --------------------------- changes from PR #31: use the UxPlay server-name as the widow name.
…een-sharing software antimof#31 (should have been part of previous commi)
see the implementation as an cmake option in PR #58, which is a full update of UxPlay |
Gstreamer does not set the _NET_WM_NAME property on the window it
creates when using
autovideosink
(or ximagesink/xvimagesink for thatmatter).
A lot of tools (like Zoom) filter based on this field being non-null, so
the window can't be shared.
This horrible hack finds the first open window that matches our application
name and proceeds to set _NET_WM_NAME on it.
It is very ugly, and I do not know what I am doing, but it works. Feel free to use this to write something that makes more sense.