Fixed duplicating fields when overriding

anti-social · Sep 23, 2021 · 9df6bb3 · 9df6bb3
1 parent b3bb01c
commit 9df6bb3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -78,6 +78,9 @@ allprojects {
             }
         }
 
+        tasks.findByName("nativeTest")?.run {
+            outputs.upToDateWhen { false }
+        }
         tasks.findByName("jvmTest")?.run {
             outputs.upToDateWhen { false }
 

diff --git a/src/commonMain/kotlin/dev/evo/elasticmagic/Document.kt b/src/commonMain/kotlin/dev/evo/elasticmagic/Document.kt
@@ -126,19 +126,24 @@ class BoundJoinField(
  */
 abstract class FieldSet : Named {
     private val fields: ArrayList<AnyField> = arrayListOf()
-    private val fieldsByName: HashMap<String, AnyField> = hashMapOf()
+    private val fieldsByName: HashMap<String, Int> = hashMapOf()
 
     internal fun addField(field: AnyField) {
-        fields.add(field)
-        fieldsByName[field.getFieldName()] = field
+        val existingFieldIx = fieldsByName[field.getFieldName()]
+        if (existingFieldIx != null) {
+            fields[existingFieldIx] = field
+        } else {
+            fieldsByName[field.getFieldName()] = fields.size
+            fields.add(field)
+        }
     }
 
     internal fun getAllFields(): List<AnyField> {
         return fields.toList()
     }
 
     internal fun getFieldByName(name: String): AnyField? {
-        return fieldsByName[name]
+        return fields[fieldsByName[name] ?: return null]
     }
 
     fun <T> field(