Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Return rather than Linefeed when typing with xdotool #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edef1c
Copy link

@edef1c edef1c commented Oct 23, 2024

Most applications don't recognise the Linefeed key (and thus ignore it), so we replace \n with \r, which sends the Return key instead. This makes multi-line input work correctly.

@x5a
Copy link
Collaborator

x5a commented Oct 23, 2024

@edef1c we're discussing this internally - thanks for your contribution. We unfortunately cannot accept unsigned commits - see this comment for more details on how to correct.

@x5a
Copy link
Collaborator

x5a commented Oct 23, 2024

@edef1c can you share a little bit more about the use case where you're seeing this? in most cases, the model should prefer a computer key <return> action

Most applications don't recognise the Linefeed key, so we replace \n
with \r, which sends the Return key instead.
@edef1c
Copy link
Author

edef1c commented Nov 1, 2024

@edef1c we're discussing this internally - thanks for your contribution. We unfortunately cannot accept unsigned commits - see this comment for more details on how to correct.

Done.

@edef1c can you share a little bit more about the use case where you're seeing this? in most cases, the model should prefer a computer key <return> action

It doesn't do so consistently. My rather synthetic test was to ask it to open up Jupyter Lab and type some code. It's not consistently reproduced by asking it to open a graphical text editor and type some text with newlines, but it can be made consistent with some coaxing. I'm perfectly happy with the model behaviour here: it seems pointless to spend several tool use cycles to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants