fix(setup): handle OS-specific venv activation path #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support both Windows and Linux/macOS venv activation - Use `.venv/Scripts/activate` for Windows - Use `.venv/bin/activate` for Linux/macOS
elharony
force-pushed
the
fix-virtual-environment-activation-path-windows
branch
from
f939a67
to
cfc047e
Compare
x5a
approved these changes
Oct 29, 2024
|
Thanks for your contribution @elharony. However, we require signed commits to merge your changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses issue #129, modifying the virtual environment activation script to handle different OS-specific paths for activating the virtual environment. It introduces a condition to support both Windows and Linux/macOS environments.
Changes:
.venv/Scripts/activatefor Windows..venv/bin/activatefor Linux/macOS.Why:
This change ensures the setup script works consistently across multiple operating systems, improving developer experience.
Testing:
Tested on both Windows and Linux/macOS environments to ensure the correct activation path is used based on the OS.