Support single quotes in attribute for the declaration node #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the `AddAttr` function to trim both double and single quotes from attribute values. Added a test to ensure XML attributes with single quotes are correctly parsed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug where parsing a declaration node that uses single quotes for its attributes would result in wrong values in the attribute list, causing the input:
<?xml version='1.0' encoding='utf-8'?>To generate the following output:
<?xml version="'1.0'" encoding="'utf-8'"?>I modified the
AddAttrfunction to trim both double and single quotes from attribute values. Added a test to ensure XML attributes with single quotes are correctly parsed.