Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Some minor features optimization #83

Merged
merged 1 commit into from
Jan 16, 2024
Merged

🐛 fix: Some minor features optimization #83

merged 1 commit into from
Jan 16, 2024

Conversation

ModestFun
Copy link
Collaborator

  1. export type NodeProps
  2. export screenToFlowPosition for FlowEditorInstance
  3. fix bug: FlowEditor won't always loading when nodes empty
  4. add deselectAll before delete
  5. add deleteNodes and deleteEdges function

1. export type NodeProps
2. export screenToFlowPosition for FlowEditorInstance
3. fix bug: FlowEditor won't always loading when nodes empty
4. add deselectAll before delete
5. add deleteNodes and deleteEdges function
Copy link

github-actions bot commented Jan 16, 2024

🎊 PR Preview 4e8e4e5 has been successfully built and deployed to https://ant-design-pro-flow-preview-pr-83.surge.sh

🕐 Build time: 64.605s

🤖 By surge-preview

@codecov-commenter
Copy link

Codecov Report

Attention: 77 lines in your changes are missing coverage. Please review.

Comparison is base (ab3a670) 2.08% compared to head (4e8e4e5) 2.07%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/FlowEditor/container/FlowEditor.tsx 0.00% 18 Missing ⚠️
src/BasicGroupNode/demos/data.ts 0.00% 14 Missing ⚠️
src/FlowEditor/store/slices/nodesSlice.ts 0.00% 13 Missing ⚠️
src/FlowEditor/store/slices/edgesSlice.ts 0.00% 9 Missing ⚠️
src/FlowView/demos/data.tsx 0.00% 8 Missing ⚠️
docs/caseShow/demos/pipelineDemo.tsx 0.00% 3 Missing ⚠️
src/FlowEditor/store/slices/generalActionSlice.ts 0.00% 3 Missing ⚠️
src/FlowEditor/hooks/useFlowEditor.ts 0.00% 2 Missing ⚠️
src/FlowView/provider/FlowViewProvider.tsx 0.00% 2 Missing ⚠️
src/FlowView/provider/provider.ts 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff            @@
##           master     #83      +/-   ##
=========================================
- Coverage    2.08%   2.07%   -0.01%     
=========================================
  Files         148     148              
  Lines        9365    9390      +25     
  Branches      174     174              
=========================================
  Hits          195     195              
- Misses       9170    9195      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ModestFun ModestFun merged commit 26563c6 into master Jan 16, 2024
5 checks passed
@ModestFun ModestFun deleted the dev/1.2.2 branch January 16, 2024 08:47
@ModestFun ModestFun changed the title 🐛 fix: Some minor features optimization (#82) 🐛 fix: Some minor features optimization Jan 16, 2024
Copy link

🎉 This PR is included in version 1.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants