Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: new Components Snippet #97

Merged
merged 6 commits into from
Nov 6, 2023
Merged

✨ feat: new Components Snippet #97

merged 6 commits into from
Nov 6, 2023

Conversation

ONLY-yours
Copy link
Collaborator

@ONLY-yours ONLY-yours commented Nov 1, 2023

还有几个需要补充

  • Api Doc
  • Bash 的 Sinki 有点奇怪
  • Sinki 建议从 es 包迁移到 sinkiji ,sinki-es 用的太少了,发版也不及时

Copy link

github-actions bot commented Nov 1, 2023

🎊 PR Preview efa1bb1 has been successfully built and deployed to https://ant-design-pro-editor-preview-pr-97.surge.sh

🕐 Build time: 127.933s

🤖 By surge-preview

@ONLY-yours ONLY-yours changed the title ✨[WIP] feat: new Components Snippet init ✨ feat: new Components Snippet Nov 1, 2023
@ONLY-yours
Copy link
Collaborator Author

@rdmclin2 Siki 的两个麻烦哥看看。
image

feat: use shikiji to replace shikiji-es
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Attention: 75 lines in your changes are missing coverage. Please review.

Comparison is base (5c2988e) 87.43% compared to head (efa1bb1) 87.39%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   87.43%   87.39%   -0.05%     
==========================================
  Files         339      349      +10     
  Lines       21885    22384     +499     
  Branches      982     1008      +26     
==========================================
+ Hits        19136    19562     +426     
- Misses       2749     2822      +73     
Files Coverage Δ
src/ContextMenu/demos/index.tsx 100.00% <100.00%> (ø)
src/Highlight/components/CopyButton/index.tsx 87.71% <100.00%> (+0.21%) ⬆️
src/Highlight/components/HighLightJS/index.tsx 96.92% <100.00%> (ø)
src/Highlight/components/HighLighter/index.tsx 85.96% <100.00%> (+2.29%) ⬆️
src/Highlight/defalut.tsx 100.00% <100.00%> (ø)
src/Highlight/demos/config.js 100.00% <100.00%> (ø)
src/Highlight/hooks/useShiki.tsx 80.00% <100.00%> (+2.22%) ⬆️
src/Highlight/index.tsx 100.00% <100.00%> (ø)
src/Highlight/style.ts 100.00% <100.00%> (ø)
src/Highlight/wrapper.tsx 100.00% <100.00%> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rdmclin2 rdmclin2 self-requested a review November 6, 2023 05:57
Copy link
Member

@rdmclin2 rdmclin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rdmclin2 rdmclin2 merged commit 25bb6ec into main Nov 6, 2023
4 checks passed
@rdmclin2 rdmclin2 deleted the feat/Snippet branch November 6, 2023 05:58
Copy link

github-actions bot commented Nov 6, 2023

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants