Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/add doc cheat sheet links #578

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Conversation

PipKat
Copy link
Member

@PipKat PipKat commented Aug 11, 2023

Per Landon’s request in the PyAnsys Global AFT on 7/26/23, add links to the PyAEDT cheat sheets from this library's documentation.

Note: This library doesn't reuse the README content in the overall index.rst file for documentation (although I am unsure why it doesn't because the content is basically the same). Regardless, I added a new "Documentation and issues" section in both the README and the overall index.rst file.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #578 (47e24d0) into main (5e22c16) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   77.48%   77.48%           
=======================================
  Files          31       31           
  Lines        2207     2207           
=======================================
  Hits         1710     1710           
  Misses        497      497           

@PipKat
Copy link
Member Author

PipKat commented Aug 14, 2023

@AlejandroFernandezLuces @ninad-kamat I'm awaiting approval from someone to merge this PR. Thanks!

@PipKat
Copy link
Member Author

PipKat commented Aug 15, 2023

@RobPasMue This PR has been sitting here for several days with no review/approval. Would you mind reviewing. It simply adds cheat sheet links in "Documentation and issues sections" like the several other PRs I submitted last week. (I'm assuming that Alex and Ninad are out of the office.)

@waltersma waltersma self-requested a review August 15, 2023 17:02
@waltersma
Copy link
Contributor

@RobPasMue , @PipKat , approved.

@PipKat
Copy link
Member Author

PipKat commented Aug 15, 2023

@waltersma @RobPasMue Thanks, Martin, for approving. I am unable to merge, but I'm not sure why. If one of you could merge this PR, I'd appreciate it!

@waltersma waltersma merged commit 7202026 into main Aug 15, 2023
22 checks passed
@waltersma waltersma deleted the docs/add_doc_cheat_sheet_links branch August 15, 2023 19:58
@RobPasMue
Copy link
Member

Thank you both! I must have missed this PR - sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants