-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint: remove importlib-metadata requirement #3546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koubaa
requested review from
germa89 and
pyansys-ci-bot
and removed request for
a team
November 12, 2024 12:19
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
CI/CD
Related with CICD, Github Actions, etc
documentation
Documentation related (improving, adding, etc)
dependencies
maintenance
General maintenance of the repo (libraries, cicd, etc)
labels
Nov 12, 2024
koubaa
changed the title
remove importlib-metadata requirement
[maint] remove importlib-metadata requirement
Nov 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3546 +/- ##
==========================================
- Coverage 87.48% 87.46% -0.03%
==========================================
Files 58 58
Lines 10217 10216 -1
==========================================
- Hits 8938 8935 -3
- Misses 1279 1281 +2 |
…nto remove-importlib
For future references: https://docs.python.org/3/library/importlib.metadata.html
|
germa89
approved these changes
Nov 13, 2024
germa89
changed the title
[maint] remove importlib-metadata requirement
maint: remove importlib-metadata requirement
Nov 13, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/CD
Related with CICD, Github Actions, etc
dependencies
documentation
Documentation related (improving, adding, etc)
maintenance
General maintenance of the repo (libraries, cicd, etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should not be required anymore in the version range that we support (importlib.metadata is builtin now)