Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: remove importlib-metadata requirement #3546

Merged
merged 5 commits into from
Nov 13, 2024
Merged

maint: remove importlib-metadata requirement #3546

merged 5 commits into from
Nov 13, 2024

Conversation

koubaa
Copy link
Contributor

@koubaa koubaa commented Nov 12, 2024

It should not be required anymore in the version range that we support (importlib.metadata is builtin now)

@koubaa koubaa requested a review from a team as a code owner November 12, 2024 12:19
@koubaa koubaa requested review from germa89 and pyansys-ci-bot and removed request for a team November 12, 2024 12:19
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc) dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Nov 12, 2024
@koubaa koubaa changed the title remove importlib-metadata requirement [maint] remove importlib-metadata requirement Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base (baa7ac0) to head (501141b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3546      +/-   ##
==========================================
- Coverage   87.48%   87.46%   -0.03%     
==========================================
  Files          58       58              
  Lines       10217    10216       -1     
==========================================
- Hits         8938     8935       -3     
- Misses       1279     1281       +2     

@germa89
Copy link
Collaborator

germa89 commented Nov 13, 2024

For future references: https://docs.python.org/3/library/importlib.metadata.html

Python documentation
Source code: Lib/importlib/metadata/__init__.py importlib.metadata is a library that provides access to the metadata of an installed Distribution Package, such as its entry points or its top-level ...

@germa89 germa89 changed the title [maint] remove importlib-metadata requirement maint: remove importlib-metadata requirement Nov 13, 2024
@germa89 germa89 merged commit 3328052 into main Nov 13, 2024
60 of 63 checks passed
@germa89 germa89 deleted the remove-importlib branch November 13, 2024 13:26
@germa89 germa89 mentioned this pull request Nov 16, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc dependencies documentation Documentation related (improving, adding, etc) maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants