Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fluid result averaging, FluidMeshInfo, and Faces #435

Merged
merged 43 commits into from
Jul 26, 2023
Merged

Add fluid result averaging, FluidMeshInfo, and Faces #435

merged 43 commits into from
Jul 26, 2023

Commits on Jul 21, 2023

  1. Raise for plot on empty Dataframe

    @PProfizi
    PProfizi committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    15fa5da View commit details
    Browse the repository at this point in the history

  2. Add location argument to generic result requests

    @PProfizi
    PProfizi committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    25ac22b View commit details
    Browse the repository at this point in the history

  3. Integrated results mass_flow_rate and surface_heat_rate are only avai… 

    …lable on faces
    @PProfizi
    PProfizi committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    c4a3a3a View commit details
    Browse the repository at this point in the history

  4. Mark integrated results

    @PProfizi
    PProfizi committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    4864351 View commit details
    Browse the repository at this point in the history

  5. Fix and mark requests on cells as filtering-out face zone IDs

    @PProfizi
    PProfizi committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    db5e6ec View commit details
    Browse the repository at this point in the history

  6. Introduce the native_location dynamic argument

    @PProfizi
    PProfizi committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    f8584c8 View commit details
    Browse the repository at this point in the history

  7. Add first averaging tests for fluid

    @PProfizi
    PProfizi committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    47ce406 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Fix surface_heat_rate and surface_heat_rate_on_faces

    @PProfizi
    PProfizi committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    d3eb81f View commit details
    Browse the repository at this point in the history

  2. Add back enthalpy_on_faces

    @PProfizi
    PProfizi committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    4eb1146 View commit details
    Browse the repository at this point in the history

  3. Allow query of surface_heat_rate (on faces) using a list of cell IDs

    @PProfizi
    PProfizi committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    2a972ec View commit details
    Browse the repository at this point in the history

  4. Add face methods in selection.py: select_faces, select_nodes_of_faces… 

    …, select_faces_of_elements
    @PProfizi
    PProfizi committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    a222f4a View commit details
    Browse the repository at this point in the history

  5. Update FluidSimulation._build_selection to correctly handle requests … 

    …with faces
    @PProfizi
    PProfizi committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    d99e7fd View commit details
    Browse the repository at this point in the history

  6. Add Mesh.num_faces, Mesh.faces, Mesh.face_to_node_ids_connectivity, M… 

    …esh.face_to_node_connectivity
    @PProfizi
    PProfizi committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    a7c6035 View commit details
    Browse the repository at this point in the history

  7. Add faces.py

    @PProfizi
    PProfizi committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    c262013 View commit details
    Browse the repository at this point in the history

  8. Add Mesh.face_ids

    @PProfizi
    PProfizi committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    55b9bdc View commit details
    Browse the repository at this point in the history

  9. Raise on dataframe.plot when empty mesh index

    @PProfizi
    PProfizi committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    1926b86 View commit details
    Browse the repository at this point in the history

  10. Fix Selection.select_nodes_of_faces

    @PProfizi
    PProfizi committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    7480605 View commit details
    Browse the repository at this point in the history

  11. Only ask to filter cell zones on request with zones or qualifiers for… 

    … location.faces too
    @PProfizi
    PProfizi committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    89bf70a View commit details
    Browse the repository at this point in the history

  12. Add test_mesh_faces

    @PProfizi
    PProfizi committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    47f6774 View commit details
    Browse the repository at this point in the history

  13. Raise in FluidSimulation result APIs when result is not available (sh… 

    …ould do the same for mechanical simulations)
    @PProfizi
    PProfizi committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    e729957 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Move mesh_info pproperty from Simulation to FluidSimulation

    @PProfizi
    PProfizi committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    8402461 View commit details
    Browse the repository at this point in the history

  2. Commit new fluid tests for averaging and cross location requests

    @PProfizi
    PProfizi committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2877d39 View commit details
    Browse the repository at this point in the history

  3. Add MeshInfo, simplify 'zones' to cell_zones and face_zones dictionaries

    @PProfizi
    PProfizi committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    ef1b6fe View commit details
    Browse the repository at this point in the history

  4. Add MeshInfo.cell_zones_to_face_zones

    @PProfizi
    PProfizi committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6b62ee9 View commit details
    Browse the repository at this point in the history

  5. Fix FluidSimulation._try_get_result_info

    @PProfizi
    PProfizi committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    15d3b9d View commit details
    Browse the repository at this point in the history

  6. Add filtering of zones for ElementalAndFaces and raise due to current… 

    … bug when querying with a faces_scoping
    @PProfizi
    PProfizi committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1158676 View commit details
    Browse the repository at this point in the history

  7. Fix test_fluid_simulation_result_unavailable

    @PProfizi
    PProfizi committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1db1a9c View commit details
    Browse the repository at this point in the history

  8. Fix raise error when querying ElementalAndFaces results with a face_s… 

    …coping
    @PProfizi
    PProfizi committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    e7c5eff View commit details
    Browse the repository at this point in the history

  9. Remove capability to ask for results on faces using cell_ids -> trans… 

    …pose needs fix
    @PProfizi
    PProfizi committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    27f2d9d View commit details
    Browse the repository at this point in the history

  10. Update test_fluid_simulation.py with raise error on ElementalAndFaces… 

    … result query with a face_scoping
    @PProfizi
    PProfizi committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    adf6287 View commit details
    Browse the repository at this point in the history

  11. Fix test since cell_ids not available for query on face results

    @PProfizi
    PProfizi committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    a356bce View commit details
    Browse the repository at this point in the history

  12. Fix Mesh docstrings

    @PProfizi
    PProfizi committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    4fe9478 View commit details
    Browse the repository at this point in the history

  13. Fix retro

    @PProfizi
    PProfizi committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    76a63b2 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Add coverage to faces.py

    @PProfizi
    PProfizi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    1dc7a69 View commit details
    Browse the repository at this point in the history

  2. Improve coverage of mesh.py

    @PProfizi
    PProfizi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    46e6658 View commit details
    Browse the repository at this point in the history

  3. Improve coverage of mesh_info.py

    @PProfizi
    PProfizi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    785d1d2 View commit details
    Browse the repository at this point in the history

  4. Improve coverage of selection.py

    @PProfizi
    PProfizi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3e889f4 View commit details
    Browse the repository at this point in the history

  5. Fix MeshInfo docstring

    @PProfizi
    PProfizi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    2943594 View commit details
    Browse the repository at this point in the history

  6. Update FluidMeshInfo docstring

    @PProfizi
    PProfizi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ea7b6da View commit details
    Browse the repository at this point in the history

  7. Update faces.py

    @PProfizi
    PProfizi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    77c29c2 View commit details
    Browse the repository at this point in the history

  8. Fix MeshInfo docstring

    @PProfizi
    PProfizi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    0dbf302 View commit details
    Browse the repository at this point in the history

  9. Fix test_spatial_selection_select_named_selection

    @PProfizi
    PProfizi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    f76a819 View commit details
    Browse the repository at this point in the history

  10. Update test_fluid_simulation.py per comments

    @PProfizi
    PProfizi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4204663 View commit details
    Browse the repository at this point in the history