-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify library installation #909
Conversation
…d src/ansys/grpc/. This should be overriden when updating using "git add --force my/ignore/file.foo"
Codecov Report
@@ Coverage Diff @@
## master #909 +/- ##
==========================================
- Coverage 87.39% 86.13% -1.27%
==========================================
Files 81 81
Lines 9197 9197
==========================================
- Hits 8038 7922 -116
- Misses 1159 1275 +116 |
…s_test.txt having it as dependency)
…ing in requirements_test.txt having it as dependency)
@@ -0,0 +1,310 @@ | |||
from typing import NamedTuple | |||
import numpy as np | |||
import weakref |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please point me to how we now handle using local binaries?
# Conflicts: # .github/workflows/ci_release.yml # pyproject.toml # requirements/requirements_dev.txt # requirements/requirements_install.txt
Co-authored-by: PProfizi <[email protected]>
# Conflicts: # requirements/requirements_dev.txt
…1132) * update operators * Update ci.yml --------- Co-authored-by: PProfizi <[email protected]> Co-authored-by: Paul Profizi <[email protected]>
# Conflicts: # .github/workflows/ci.yml # .github/workflows/pydpf-post.yml # docs/source/_static/dpf_operators.html
print(f"{grpc_path_key} environment variable is not defined. " | ||
"Cannot update ansys-grpc-dpf.") | ||
|
||
if gate_path is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be great to run the "cparser" step to generate ansys-dpf-gate/generated content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and generation of ansys-grpc-dpf
@@ -4,7 +4,8 @@ call sphinx-apidoc -o ../docs/source/api ../src/ansys ../src/ansys/dpf/core/log. | |||
../src/ansys/dpf/core/field_base.py ../src/ansys/dpf/core/cache.py ../src/ansys/dpf/core/misc.py ^ | |||
../src/ansys/dpf/core/check_version.py ../src/ansys/dpf/core/operators/build.py ../src/ansys/dpf/core/operators/specification.py ^ | |||
../src/ansys/dpf/core/vtk_helper.py ../src/ansys/dpf/core/label_space.py ../src/ansys/dpf/core/examples/python_plugins/* ^ | |||
../src/ansys/dpf/core/examples/examples.py ../src/ansys/dpf/core/property_fields_container.py ^ | |||
../src/ansys/dpf/core/examples/examples.py ../src/ansys/dpf/gate/* ../src/ansys/dpf/gatebin/* ../src/ansys/grpc/dpf/* ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal of this PR is to simplify installation of pydpf-core when a user does
pip install ansys-dpf-core
:ansys-dpf-gate
andansys-grpc-dpf
as packages of theansys-dpf-core
library instead of separate packages, ensuring synchronization at install (only works for Ansys >= 222)ansys-dpf-gatebin
binaries (windows
andmanylinux_1
) which are loaded at runtime when requiredansys-dpf-gate
,ansys-dpf-gatebin
andansys-grpc-dpf
to accept a custom path (the one of the pydpf-core repo) (push version).ci
which updates all dependencies (pull version) based on two environment variables: one for ansys-grpc-dpf, one for ansys-dpf-gate and ansys-dpf-gatebin.update_operators
pipeline to also update ansys-dpf-gate, gatebin and ansys-grpc-dpf according to the latest indpf-standalone/dist