Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all example files downloadable #1126

Merged
merged 25 commits into from
Sep 14, 2023

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Aug 29, 2023

Removes result files under src/ansys/dpf/core/examples from the repository and makes them downloadable like all the others.

ansys-dpf-core wheel size:

  • initially 19.1 MB
  • new 1.729 MB

Edit: post-refactor, with ansys-dpf-gate/gatebin/grpc-dpf:

  • initially 32 MB
  • new 15.2 MB

PR on Post to go with it: ansys/pydpf-post#475

@PProfizi PProfizi added the maintenance Repository structure maintenance label Aug 29, 2023
@PProfizi PProfizi self-assigned this Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1126 (f541c60) into master (b210f84) will decrease coverage by 0.11%.
Report is 1 commits behind head on master.
The diff coverage is 81.03%.

@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
- Coverage   87.36%   87.25%   -0.11%     
==========================================
  Files          81       81              
  Lines        9197     9221      +24     
==========================================
+ Hits         8035     8046      +11     
- Misses       1162     1175      +13     

@PProfizi PProfizi merged commit b11cdbf into master Sep 14, 2023
27 of 28 checks passed
@PProfizi PProfizi deleted the maint/make_all_examples_downloadable branch September 14, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Repository structure maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants