Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: caching bodies to avoid unnecessary object creation #1513

Merged
merged 6 commits into from
Oct 28, 2024

Conversation

RobPasMue
Copy link
Member

Description

Allow for body caching if no new bodies have been added. This reduces the amount of time we spend on object creation...

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Oct 25, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner October 25, 2024 07:52
@github-actions github-actions bot added the enhancement New features or code improvements label Oct 25, 2024
@RobPasMue
Copy link
Member Author

Needs investigation from my side... let's see what's going on.

@RobPasMue
Copy link
Member Author

Okay so, on body deletion we also need to clear the cache. That was missing - my bad. Ready to go now!

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@eb88ca3). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1513   +/-   ##
=======================================
  Coverage        ?   91.67%           
=======================================
  Files           ?       86           
  Lines           ?     7001           
  Branches        ?        0           
=======================================
  Hits            ?     6418           
  Misses          ?      583           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit 5e7f276 into main Oct 28, 2024
39 of 40 checks passed
@RobPasMue RobPasMue deleted the feat/cached-property-for-bodies branch October 28, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants