FIX: Fixed bug which prevented to skip healing on nastran import #5433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5433 +/- ##
===========================================
- Coverage 84.39% 41.26% -43.13%
===========================================
Files 140 140
Lines 58669 58671 +2
===========================================
- Hits 49513 24211 -25302
- Misses 9156 34460 +25304 |
SMoraisAnsys
approved these changes
Nov 15, 2024
Comment on lines
+579
to
+580
| except Exception: | ||
| pass |
There was a problem hiding this comment.
Suggested change
| except Exception: | |
| pass | |
| except Exception: # pragma: no cover | |
| logger.debug("Failed to normalize vector.") |
Comment on lines
+566
to
+567
| cv1 = GeometryOperators.v_points(fc, v2) | ||
| cv2 = GeometryOperators.v_points(fc, v1) |
There was a problem hiding this comment.
Suggested change
| cv1 = GeometryOperators.v_points(fc, v2) | |
| cv2 = GeometryOperators.v_points(fc, v1) | |
| cv1 = GeometryOperators.v_points(fc, v1) | |
| cv2 = GeometryOperators.v_points(fc, v2) |
Any reason to changes the name values ? I expected cv1 to be the distance between v1 and the center (same for cv2)
| @@ -557,32 +557,27 @@ def _write_stl(nas_to_dict, decimation, working_directory, enable_planar_merge=T | |||
| def _write_solid_stl(triangle, pp): | |||
| try: | |||
| # points = [nas_to_dict["Points"][id] for id in triangle] | |||
| points = [pp[i] for i in triangle] | |||
| points = [pp[i] for i in triangle[::-1]] | |||
There was a problem hiding this comment.
Any reason for using [::-1] ?
| @@ -341,14 +341,15 @@ def __init__( | |||
|
|
|||
| self._is_closed = close_surface | |||
| self._is_covered = cover_surface | |||
|
|
|||
| self._solve_inside = False | |||
There was a problem hiding this comment.
Why are those changes required ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.