Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Pyaedt installer in linux #5392

Merged
merged 16 commits into from
Nov 8, 2024
Merged

Conversation

SMoraisAnsys
Copy link
Collaborator

As title says.

Changes include:

  • using IronPython to create the disclaimer and abort actions if users do not approve the disclaimer;
  • strengthening the script by using subprocess.call or subprocessdotnet.call instead of os.system to avoid the vulnerability associated to the latter.

@Samuelopez-ansys I tested it with AEDT 24.2 on Linux and Windows. The installation through the GUI is working as expected.
Do you want to use the same kind of windows when working with the installation of extensions ?

Close #5390

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (e580d7a) to head (dfb3219).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5392      +/-   ##
==========================================
+ Coverage   84.31%   84.38%   +0.07%     
==========================================
  Files         140      140              
  Lines       58594    58594              
==========================================
+ Hits        49401    49443      +42     
+ Misses       9193     9151      -42     

@Samuelopez-ansys
Copy link
Member

@SMoraisAnsys Good job! Maybe it is a good idea to add it to the extension manager too

@SMoraisAnsys SMoraisAnsys merged commit 41c9e2d into main Nov 8, 2024
41 checks passed
@SMoraisAnsys SMoraisAnsys deleted the fix/pyaedt-installer-in-linux branch November 8, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install with pyaedt_installer_from_aedt.py on Linux
2 participants