Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Update wireframe method #5386

Merged
merged 5 commits into from
Nov 12, 2024
Merged

FEAT: Update wireframe method #5386

merged 5 commits into from
Nov 12, 2024

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Nov 6, 2024

Useful method to update the same property of multiple objects. If you have multiple objects, this is much more efficient that the current method, which is looping every object and change the property value one by one.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Nov 6, 2024
@Samuelopez-ansys Samuelopez-ansys marked this pull request as ready for review November 8, 2024 11:24
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) November 8, 2024 11:25
@Samuelopez-ansys Samuelopez-ansys linked an issue Nov 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (c4a1475) to head (8335d39).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5386      +/-   ##
==========================================
- Coverage   84.38%   84.38%   -0.01%     
==========================================
  Files         140      140              
  Lines       58599    58635      +36     
==========================================
+ Hits        49451    49481      +30     
- Misses       9148     9154       +6     

SMoraisAnsys
SMoraisAnsys previously approved these changes Nov 8, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM It will be usefull for sure !
I left some minor comments.

src/ansys/aedt/core/modeler/cad/primitives.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modeler/cad/primitives.py Show resolved Hide resolved
tests/system/general/test_08_Primitives3D.py Show resolved Hide resolved
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@Samuelopez-ansys Samuelopez-ansys merged commit 33278b9 into main Nov 12, 2024
42 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/issue_5384 branch November 12, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set properties in parallel Update property of multiple objects
3 participants