Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: General code improvements #5378

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

Changes include:

  • use of defusedxml to safely parse an XML file;
  • use of secrets to generate random values between 0 and 255;
  • raise RuntimeError instead of using assert in code.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (ea34abc) to head (8092703).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5378      +/-   ##
==========================================
- Coverage   84.36%   84.36%   -0.01%     
==========================================
  Files         140      140              
  Lines       58451    58459       +8     
==========================================
+ Hits        49312    49317       +5     
- Misses       9139     9142       +3     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMoraisAnsys SMoraisAnsys merged commit 9f0e163 into main Nov 6, 2024
42 checks passed
@SMoraisAnsys SMoraisAnsys deleted the refactor/general-code-improvement branch November 6, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants