Add saving now optional, Fix crop! error for element out of viewport #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added option to save the screenshot or just to recieve it back as ChunkyPNG::Image so users are now able to work with the image in their automated test. Fixed error of crop! when the element was too big for the viewport or when it was somewhere in the middle of the page. Know problem - You still need to scroll to the element and it needs to be visible on the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to save the screenshot or just to recieve it back as
ChunkyPNG::Image so users are now able to work with the image in
their automated test.
Fixed error of crop! when the element was too big for the viewport
or when it was somewhere in the middle of the page.
Know problem - You still need to scroll to the element and it needs
to be visible on the page.