some cross-platform portability changes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - made it possible to override ANSILOVE_EXTERN with something that's not GNU specific - re-implemented strndup in compat/ This makes it possible to compile the core functionality of libansilove (specifically, ansilove_ansi() and friends) with MSVC, if some implementation of GD is available. The _init(), _loadfile() and _clean() functions don't work yet, as they are centered around POSIX-exclusive APIs. This functionality is easily replaced by a few lines of glue code though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a project where I want to integrate libansilove into another application, but there's a catch: It needs to work on Windows and be compiled with Microsoft's compiler. Given that libansilove's
_init(),_loadfile()and_clean()APIs are centered around POSIX'mmapAPI, these are not easily replaceable with something portable, but that's not a problem, as they are nearly trivial to reimplement. The good news is that the core of the library (i.e.ansilove_ansi()and friends) can be coerced into working, with the following two minor changes, which are part of this PR:ANSILOVE_EXTERNwith something that's not GNU specificstrndupincompat/