Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libssh in manylinux containers to v0.10.3 #440

Closed

Conversation

webknjaz
Copy link
Member

SUMMARY

$sbj.

ISSUE TYPE
  • Maintenance Pull Request

@webknjaz webknjaz added the bot:chronographer:skip This PR does not need to include a change note label Nov 12, 2022
@webknjaz webknjaz self-assigned this Nov 12, 2022
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/ansible-pylibssh-440
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@webknjaz webknjaz changed the title Bump libssh in manylinux containers to v0.9.6 Bump libssh in manylinux containers to v0.10.3 Nov 12, 2022
@webknjaz webknjaz marked this pull request as ready for review November 12, 2022 19:12
@webknjaz
Copy link
Member Author

Got an error in manylinux1:

+ make
/tmp/libssh-0.10.3-manylinux-build.kuFwLKNWc4/libssh-0.10.3/src/config.c: In function ‘ssh_config_parse_line’:
/tmp/libssh-0.10.3-manylinux-build.kuFwLKNWc4/libssh-0.10.3/src/config.c:1021:26: error: ‘LLONG_MAX’ undeclared (first use in this function)
                 if (ll > LLONG_MAX / 1024) {
                          ^
/tmp/libssh-0.10.3-manylinux-build.kuFwLKNWc4/libssh-0.10.3/src/config.c:1021:26: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [src/CMakeFiles/ssh.dir/config.c.o] Error 1
make[1]: *** [src/CMakeFiles/ssh.dir/all] Error 2
make: *** [all] Error 2
error building at STEP "RUN ./install_libssh.sh "${LIBSSH_VERSION}"": error while running runtime: exit status 2
time="2022-11-12T17:14:59Z" level=error msg="exit status 2"

Per https://stackoverflow.com/questions/47101031/llong-max-missing-for-g-4-9-4, libssh v0.10.3 may require newer glibc which wouldn't be compatible with manylinux1.
So this PR needs to be revisited after #437 / #324.

@webknjaz webknjaz closed this Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant