Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor contentfinder and collectionloader to use ansible-doc where possible #262

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

jctanner
Copy link
Collaborator

followup from #261

No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
@jctanner
Copy link
Collaborator Author

@felixfontein is there anything I can add to the tests to catch whatever zuul was complaining about? Could you point me at the test that failed maybe?

No-Issue

Signed-off-by: James Tanner <[email protected]>
@felixfontein
Copy link
Contributor

@jctanner one Zuul failure is here: https://fa21944ca58e915dfb0e-2ed5cf1d0adaac8ad75a43940c07b553.ssl.cf5.rackcdn.com/7887/b16af21fec0dded0d7d168bc729ba7bc042b57b9/third-party-check/ansible-galaxy-importer/bcb5b9a/job-output.txt (PR: ansible-collections/community.general#7887)

The Zuul log looks for ERROR: in the importer output and fails if it finds such. In this case there is:

2024-01-23 06:52:12.622735 | controller | ERROR: Error running ansible-doc: cmd="/usr/bin/env ANSIBLE_COLLECTIONS_PATHS=/tmp/tmpbs6ghggh ANSIBLE_LOCAL_TEMP=~/.ansible/tmp ansible-doc --type filter --json community.general.version_sort community.general.unicode_normalize community.general.to_ini community.general.time community.general.random_mac community.general.lists_mergeby community.general.json_query community.general.jc community.general.hashids community.general.groupby_as_dict community.general.from_ini community.general.from_csv community.general.dict_kv community.general.dict community.general.crc32 community.general.counter" returncode="1" b'\''[DEPRECATION WARNING]: ANSIBLE_COLLECTIONS_PATHS option, does not fit var \nnaming standard, use the singular form ANSIBLE_COLLECTIONS_PATH instead. This \nfeature will be removed from ansible-core in version 2.19. Deprecation warnings\n can be disabled by setting deprecation_warnings=False in ansible.cfg.\nERROR! filter community.general.time missing documentation (or could not parse documentation): No documentation available for community.general.time (/tmp/tmpbs6ghggh/ansible_collections/community/general/plugins/filter/time.py)\n'\''

These errors should no longer happen due to #261.

No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
No-Issue

Signed-off-by: James Tanner <[email protected]>
Copy link

sonarcloud bot commented Jul 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants