Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Looking For Feedback] Add feature app #626

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

john-westcott-iv
Copy link
Member

Adds a DAB application whose goal is to give the platform a standard way to have "feature flags".
This would enable us to develop features which could be enabled/disabled by an admin user.
There are likely many aspects of development which would need to be thought about for feature development.

Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
62.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@chrismeyersfsu
Copy link
Member

I like that this is a separate app. I could see this being its own microservice .. but not now .. for god sakes not now.

👍 ➕

I'm going to go into bigger picture thoughts. Features flagging is, basically, settings. The landscape of considerations that come with settings. Being able to change the value without restart the system and have them take effect, this is a cache problem. Particularly, invalidation when a value changes. Controller has a hacky feature for reloading rsyslog when external logging config changes. We run a service that listen to pgnotify. A signal is sent when the external logging settings are sent, the service re-writes the rsyslog config file and restart the service.

@TheRealHaoLiu has given thought to this topic.

`short_name` str, an easy to reference name that will be used as an identifier inside the code
`name` str, the display name for the feature (end user facing)
`description` str, a brief description of the feature
`status` one of ['a', 'b'], the status of the feature (Alpha or Beta, see Feature Status)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we should also have teach preview and GA? Because there will be normal supported features here?

@matburt
Copy link
Member

matburt commented Oct 14, 2024

I kinda disagree with what this is doing... Feature Flags isn't a core capability of AAP, we'd have to maintain this. This is something we should pull off the shelf and my handbook FF proposal does just that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants