[HOLD] Only allow x-trusted-proxy header to be valid for so long #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
john-westcott-iv
added
the
Ready for review
AlanCoding
reviewed
Aug 20, 2024
| @@ -42,6 +44,15 @@ def validate_x_trusted_proxy_header(header_value: str, ignore_cache=False) -> bo | |||
| logger.warning("Failed to validate x-trusted-proxy-header, malformed, expected value to contain a -") | |||
| return False | |||
|
|
|||
| # Validate that the header has been cut within the last 300ms (by default) | |||
| try: | |||
| if time.time_ns() - int(timestamp) > get_setting('trusted_header_timeout_in_ns', 300000000): | |||
There was a problem hiding this comment.
This requires that the clocks from the proxy server and the local server (using this auth class) are synced. I just want to have that in writing here.
AlanCoding
approved these changes
Aug 20, 2024
john-westcott-iv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.