Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Third Party Auth #15571

Merged
merged 10 commits into from
Oct 15, 2024
Merged

Removal of Third Party Auth #15571

merged 10 commits into from
Oct 15, 2024

Conversation

jessicamack
Copy link
Member

SUMMARY

As referenced here: https://forum.ansible.com/t/transitioning-authentication-and-authorization-rbac-to-the-new-awx-architecture

ISSUE TYPE
  • Breaking Change
COMPONENT NAME
  • API
  • UI
  • Collection
  • CLI
  • Docs
  • Other
AWX VERSION

ADDITIONAL INFORMATION

@github-actions github-actions bot added component:api component:awx_collection issues related to the collection for controlling AWX component:cli component:docs dependencies Pull requests that update a dependency file labels Oct 2, 2024
@TheRealHaoLiu TheRealHaoLiu force-pushed the feature_3rd-party-auth-removal branch 3 times, most recently from a18388d to 7a665a2 Compare October 2, 2024 18:58
Copy link
Collaborator

@hakbailey hakbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the inline comments, we should remove the part of the requirements README that references social-auth-app-django, which has been removed.

awx/api/views/__init__.py Outdated Show resolved Hide resolved
pre-commit.sh Outdated Show resolved Hide resolved
@chrismeyersfsu
Copy link
Member

chrismeyersfsu commented Oct 15, 2024

I see sso app migrations deleted. I can see this working for a new install but does it break upgrading?

I looked for, but didn’t find, the deletion of the sso app from the Django app list. On mobile right now, going to look again on the desktop and update my comment.

edit: I see that the awx.sso app has been removed from the app list 👍 and @TheRealHaoLiu helped me find the special sauce migration https://github.com/ansible/awx/pull/15571/files#diff-55acf9c639221d7558ed496c210bfc76ec7ee5a037faae48adcc5a000499fc22 👍

I approve this PR.

@TheRealHaoLiu TheRealHaoLiu force-pushed the feature_3rd-party-auth-removal branch 2 times, most recently from 4eed8c2 to 5d80cad Compare October 15, 2024 20:17
ldjebran and others added 10 commits October 15, 2024 16:17
Remove LDAP authentication from AWX
Remove TACACS+ authentication from AWX.

Co-authored-by: Hao Liu <[email protected]>
Remove RADIUS authentication from AWX

Do not remove models fields and tables let it for a stage where all the work of removing external auth finished AAP-27707

Co-authored-by: Hao Liu <[email protected]>
Remove social oauth (Azure, Github, Google)

Co-authored-by: jessicamack <[email protected]>
* Removed docs associated with SAML auth.

* Removed more mentions about SAML.

---------

Co-authored-by: jessicamack <[email protected]>
* remove oidc

* remove test fields, linting fix

* merge commit
* remove saml

* remove license file and management command

* update requirements, add migrations

* remove unused imports
- Sequentiallize auth config removal migrations
- Remove references to third party auth
- update license files
- lint fix
- Remove unneeded docs
- Remove unreferenced file
- Remove social auth references from docs
- Remove rest of sso dir
- Remove references to third part auth in docs
- Removed screenshots of UI listing removed settings
- Remove AuthView references
- Remove unused imports
...

Co-Authored-By: jessicamack <[email protected]>
Copy link

sonarcloud bot commented Oct 15, 2024

@jessicamack jessicamack merged commit 31e4770 into devel Oct 15, 2024
24 of 29 checks passed
@jessicamack jessicamack deleted the feature_3rd-party-auth-removal branch October 15, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api component:awx_collection issues related to the collection for controlling AWX component:cli component:docs dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants